public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Noah Goldstein <goldstein.w.n@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org, fweimer@redhat.com,
	 adhemerval.zanella@linaro.org
Subject: Re: [PATCH v8 1/2] x86-64: Save APX registers in ld.so trampoline
Date: Sat, 24 Feb 2024 13:01:08 -0600	[thread overview]
Message-ID: <CAFUsyfLb5cTtb6FSdB=12rQZ8ZYr0OVSXYBrONjdV5urEZFttg@mail.gmail.com> (raw)
In-Reply-To: <20240216151711.2742988-2-hjl.tools@gmail.com>

On Fri, Feb 16, 2024 at 9:17 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Add APX registers to STATE_SAVE_MASK so that APX registers are saved in
> ld.so trampoline.  This fixes BZ #31371.
>
> Also update STATE_SAVE_OFFSET and STATE_SAVE_MASK for i386 which will
> be used by i386 _dl_tlsdesc_dynamic.
> ---
>  sysdeps/x86/sysdep.h | 52 +++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 46 insertions(+), 6 deletions(-)
>
> diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h
> index 85d0a8c943..837fd28734 100644
> --- a/sysdeps/x86/sysdep.h
> +++ b/sysdeps/x86/sysdep.h
> @@ -21,14 +21,54 @@
>
>  #include <sysdeps/generic/sysdep.h>
>
> +/* The extended state feature IDs in the state component bitmap.  */
> +#define X86_XSTATE_X87_ID      0
> +#define X86_XSTATE_SSE_ID      1
> +#define X86_XSTATE_AVX_ID      2
> +#define X86_XSTATE_BNDREGS_ID  3
> +#define X86_XSTATE_BNDCFG_ID   4
> +#define X86_XSTATE_K_ID                5
> +#define X86_XSTATE_ZMM_H_ID    6
> +#define X86_XSTATE_ZMM_ID      7
> +#define X86_XSTATE_PKRU_ID     9
> +#define X86_XSTATE_TILECFG_ID  17
> +#define X86_XSTATE_TILEDATA_ID 18
> +#define X86_XSTATE_APX_F_ID    19
> +
> +#ifdef __x86_64__
>  /* Offset for fxsave/xsave area used by _dl_runtime_resolve.  Also need
>     space to preserve RCX, RDX, RSI, RDI, R8, R9 and RAX.  It must be
> -   aligned to 16 bytes for fxsave and 64 bytes for xsave.  */
> -#define STATE_SAVE_OFFSET (8 * 7 + 8)
> -
> -/* Save SSE, AVX, AVX512, mask and bound registers.  */
> -#define STATE_SAVE_MASK \
> -  ((1 << 1) | (1 << 2) | (1 << 3) | (1 << 5) | (1 << 6) | (1 << 7))
> +   aligned to 16 bytes for fxsave and 64 bytes for xsave.
> +
> +   NB: Is is non-zero because of the 128-byte red-zone.  Some registers
> +   are saved on stack without adjusting stack pointer first.  When we
> +   update stack pointer to allocate more space, we need to take the
> +   red-zone into account.  */
> +# define STATE_SAVE_OFFSET (8 * 7 + 8)
> +
> +/* Save SSE, AVX, AVX512, mask, bound and APX registers.  Bound and APX
> +   registers are mutually exclusive.  */
> +# define STATE_SAVE_MASK               \
> +  ((1 << X86_XSTATE_SSE_ID)            \
> +   | (1 << X86_XSTATE_AVX_ID)          \
> +   | (1 << X86_XSTATE_BNDREGS_ID)      \
> +   | (1 << X86_XSTATE_K_ID)            \
> +   | (1 << X86_XSTATE_ZMM_H_ID)        \
> +   | (1 << X86_XSTATE_ZMM_ID)          \
> +   | (1 << X86_XSTATE_APX_F_ID))
> +#else
> +/* Offset for fxsave/xsave area used by _dl_tlsdesc_dynamic.  Since i386
> +   doesn't have red-zone, use 0 here.  */
> +# define STATE_SAVE_OFFSET 0
> +
> +/* Save SSE, AVX, AXV512, mask and bound registers.   */
> +# define STATE_SAVE_MASK               \
> +  ((1 << X86_XSTATE_SSE_ID)            \
> +   | (1 << X86_XSTATE_AVX_ID)          \
> +   | (1 << X86_XSTATE_BNDREGS_ID)      \
> +   | (1 << X86_XSTATE_K_ID)            \
> +   | (1 << X86_XSTATE_ZMM_H_ID))
> +#endif
>
>  /* Constants for bits in __x86_string_control:  */
>
> --
> 2.43.0
>


LGTM.
Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>

  reply	other threads:[~2024-02-24 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 15:17 [PATCH v8 0/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers H.J. Lu
2024-02-16 15:17 ` [PATCH v8 1/2] x86-64: Save APX registers in ld.so trampoline H.J. Lu
2024-02-24 19:01   ` Noah Goldstein [this message]
2024-03-08 20:09     ` H.J. Lu
2024-03-09 17:39       ` Noah Goldstein
2024-02-16 15:17 ` [PATCH v8 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers H.J. Lu
2024-02-24 17:09   ` Noah Goldstein
2024-02-24 17:30     ` H.J. Lu
2024-02-24 17:39       ` Noah Goldstein
2024-02-24 18:00         ` H.J. Lu
2024-02-24 18:45           ` Noah Goldstein
2024-02-24 18:52             ` H.J. Lu
2024-02-24 18:59               ` Noah Goldstein
2024-02-24 19:00   ` Noah Goldstein
2024-02-24 19:10     ` H.J. Lu
2024-02-22 20:24 ` PING: [PATCH v8 0/2] " H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFUsyfLb5cTtb6FSdB=12rQZ8ZYr0OVSXYBrONjdV5urEZFttg@mail.gmail.com' \
    --to=goldstein.w.n@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).