From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 3804D3856945 for ; Wed, 10 May 2023 22:12:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3804D3856945 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-39420384cc4so1212606b6e.0 for ; Wed, 10 May 2023 15:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683756763; x=1686348763; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sfR3QTIuHCtFVQw9uRupaeyvSfp/ojHh3tlBi2SsAG0=; b=bZJsmA1OoidW0DJmGLkFnk8zs8g9dUt2jUqWX0AnN4ctZRN/T1Rc3rP2PbgZaDg8wn 2ZGIiJmNQDv0gc9JLvvS9KHPWJitxOX6Mz7z7hYnnT5NVLraY5DxPMDtZVRwsYCHWgsO SwvXikR7zt2EWuiBcgnQTsvirJ4lRlWEsqegVFW3W40+V/qMM+eHzmwoiVPndjZxVIQ+ 5l2zb6+Ah4ObHysnRpOBJnj+zfX/D1Ic09G+70djTUy9kKgOeqAP/Kpq4tPD/Es61oH4 +7kLcyIZSIXoaxEDPNC1WBYrswpcqZoRnPWlWIXBqEBDY+SNIs5KjWNLnZwKTabGntXW D16w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683756763; x=1686348763; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfR3QTIuHCtFVQw9uRupaeyvSfp/ojHh3tlBi2SsAG0=; b=MpKv+F/F2S+PdXZWOOCapLBGASjnRhLdUYvBiO6W7kFGfW7EkdZSC/eMxdwcjLDbHV uy8oF53dLfOUO5ICpZ1OkxKG1VvX5me9jN8S3ZXMBicjHBXUd5B8mpoUt65QwuNdrFF/ qTzVm7rZq40zcj7HBFfeoqvzuJ0hGXhH2h78yTw2pJMuGU211RTbJa5xHV1/+aSXZzOr vQEtyUhM5I7y8zkEQ3OH0kPC42dDdIiafcmsJrsVwKhBgNmvhoD+HsIsK39UwYpQaMma dTCeq3nbfvvHYUP855LnOXHlNJMO4Zh3WRXlz6Eupygb3cG/02ayV0cp5l9+EI82b3d0 /EvA== X-Gm-Message-State: AC+VfDx55jsjXuA/cbN6uIpT6wadGBBIfRZWPSzf/qU7fwrqKpf4L6nU SIkRxMh3DSwTmtGWSOXF8J4hPG/Q3fq9NzKI8UiZwKJY X-Google-Smtp-Source: ACHHUZ6N6ycEnD372THLmp0n1FgRCMrgJ4R+92w/N1cP+ql4q7iuprFz6lxbce7k6M1Guu2hWrHca9RdgwhwvuHdGRc= X-Received: by 2002:a05:6808:18b:b0:394:2499:15f8 with SMTP id w11-20020a056808018b00b00394249915f8mr2449812oic.33.1683756763437; Wed, 10 May 2023 15:12:43 -0700 (PDT) MIME-Version: 1.0 References: <20230424050329.1501348-1-goldstein.w.n@gmail.com> <20230510003336.637851-1-goldstein.w.n@gmail.com> <20230510003336.637851-4-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Wed, 10 May 2023 17:12:31 -0500 Message-ID: Subject: Re: [PATCH v6 4/4] x86: Tune 'Saltwell' microarch the same was a 'Bonnell' To: "H.J. Lu" Cc: libc-alpha@sourceware.org, carlos@systemhalted.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 10, 2023 at 5:04=E2=80=AFPM H.J. Lu wrote= : > > On Tue, May 9, 2023 at 5:34=E2=80=AFPM Noah Goldstein wrote: > > > > Saltwell is just a die shrink of Bonnell, so the same > > micro-architectural optimization preferences apply. > > --- > > sysdeps/x86/cpu-features.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c > > index 4cc1cd9fed..517b1be34c 100644 > > --- a/sysdeps/x86/cpu-features.c > > +++ b/sysdeps/x86/cpu-features.c > > @@ -678,7 +678,9 @@ init_cpu_features (struct cpu_features *cpu_feature= s) > > break; > > > > /* Unaligned load versions are faster than SSSE3 > > - on Airmont, Silvermont, Goldmont, and Goldmont Plu= s. */ > > + on Saltwell, Airmont, Silvermont, Goldmont, and Go= ldmont > > + Plus. */ > > + case INTEL_ATOM_SALTWELL: > > It should be grouped with Bonnell. > Done. > > case INTEL_ATOM_AIRMONT: > > case INTEL_ATOM_SILVERMONT: > > case INTEL_ATOM_GOLDMONT: > > @@ -710,7 +712,6 @@ init_cpu_features (struct cpu_features *cpu_feature= s) > > /* Default tuned atom microarch. */ > > case INTEL_ATOM_SIERRAFOREST: > > case INTEL_ATOM_GRANDRIDGE: > > - case INTEL_ATOM_SALTWELL: > > goto default_tuning; > > > > /* Bigcore Tuning. */ > > -- > > 2.34.1 > > > > > -- > H.J.