public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: "Carlos O'Donell" <carlos@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Add random locking benchmark
Date: Fri, 9 Dec 2022 10:49:02 -0800	[thread overview]
Message-ID: <CAFUsyfLdxs_TtmMtRH-DENKLE5Pg8kHxEg+zjWR-K4_Y=ax-dA@mail.gmail.com> (raw)
In-Reply-To: <PAWPR08MB8982921AF99622F1E88FE2FC831C9@PAWPR08MB8982.eurprd08.prod.outlook.com>

On Fri, Dec 9, 2022 at 10:15 AM Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>
> Hi Noah,
>
> > +  /* Start a short thread to force SINGLE_THREAD_P == false.  This relies on
> > +     the runtime disabling single-threaded optimizations when multiple
> > +     threads are used, even after they finish.  */
>
> > Is it worth benchmarking with some contention or is the goal
> > just SINGLE_THREAD_P true/false?
>
> The latter, the goal is just to test singlethreaded is faster and multithreaded
> is not slower. We could add a benchmark for the internal locks (which might
> test contention cases), but trying to use the internal headers in benchtests
> seems non-trivial.
>
Fair enough (reviewed this patch w.o seeing your next one initially so
was missing the context).
> > +
> > Can you remove this extra line.
>
> I don't remember ever seeing that, another oddity of git apply...
> I'll remove it in the next version.
>
> Cheers,
> Wilco

      reply	other threads:[~2022-12-09 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 15:14 Wilco Dijkstra
2022-08-22 21:13 ` Carlos O'Donell
2022-08-24 14:43   ` Wilco Dijkstra
2022-12-09 13:59     ` Wilco Dijkstra
2022-12-09 17:23       ` Noah Goldstein
2022-12-09 18:14         ` Wilco Dijkstra
2022-12-09 18:49           ` Noah Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFUsyfLdxs_TtmMtRH-DENKLE5Pg8kHxEg+zjWR-K4_Y=ax-dA@mail.gmail.com' \
    --to=goldstein.w.n@gmail.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).