From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id BC80F3989812 for ; Wed, 2 Jun 2021 21:18:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC80F3989812 Received: by mail-pg1-x532.google.com with SMTP id l1so3369223pgm.1 for ; Wed, 02 Jun 2021 14:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FkJs7Q3i22qU0ZiDiiDpsQFxr5r4h1LVWz4XHsgUnhk=; b=DvOBImB55cogBqyCYifRpgeoh0KHIJLxY7URwcc134fVnJOsPXOG7QeluLV2IuADOX m3GWN10OZXJ97MV26p6o9oKdGMtU8gaDX/Y1rieWwvAsmZvZcD0ZLkNT4E/yeJxP8oyG yozzG3+HDK7A7Z74Tt3NX0PA5gVBTAWnx5Ly3wpDZ97xc9SE45lJcNLjYLAQ0n1rzajU NI9ZU8ERXdsWDMdvUSLPOmL0Ubfp9Wqi+YrQSzorN0bHhInw4+G8X7sszXyUOGc/MbRP I+fI/YYZynbg8hBYoXjf25BaXrFL/hptX1JMG064uWgQwkqRvA7UL3bZLC0Q1niXCkto rJhQ== X-Gm-Message-State: AOAM530+KuEHRv4nF9vKXfFe4CmIKxeg3DDElsEZ2oGw2LwC1nkRYV31 VzfYD1v1v5UqWj/Vy+gp1HIv9RWc8jJYG8hz1At+53c5 X-Google-Smtp-Source: ABdhPJxXnMAIoBQ1Xr8R4IiZIAB+G9EsQ88J/Hg8obj7+J2mWGPwwyFCR7QByTbgt42ScIKE1BVaCqFiO0HLKd0RfUM= X-Received: by 2002:a65:4bce:: with SMTP id p14mr1799030pgr.408.1622668705977; Wed, 02 Jun 2021 14:18:25 -0700 (PDT) MIME-Version: 1.0 References: <20210602210022.1091086-1-skpgkp2@gmail.com> In-Reply-To: <20210602210022.1091086-1-skpgkp2@gmail.com> From: Noah Goldstein Date: Wed, 2 Jun 2021 17:18:13 -0400 Message-ID: Subject: Re: [PATCH v2] Improve test coverage of strnlen function To: Sunil K Pandey Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 21:18:28 -0000 On Wed, Jun 2, 2021 at 5:00 PM Sunil K Pandey via Libc-alpha wrote: > > This patch covers the following condition: > > Strings start with different alignments and end with length less than or > equal to 512 byte. > --- > string/test-strnlen.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/string/test-strnlen.c b/string/test-strnlen.c > index d70faa26ab..fc2519614f 100644 > --- a/string/test-strnlen.c > +++ b/string/test-strnlen.c > @@ -271,6 +271,15 @@ test_main (void) > do_test (1, 1 << i, 5000, BIG_CHAR); > } > > + size_t pagesize = getpagesize () / sizeof (CHAR); Think style of the file is variables declared at start of their scope. Also imo pagesize means something different than char per page so maybe rename. That being said I support the patch. Thanks for test improvements! > + > + for (i = 0; i <= 127; i++) > + for (size_t length = i; length <= 512; length++) > + { > + do_test (i, length, 512, BIG_CHAR); > + do_test (pagesize - i, length, 512, BIG_CHAR); > + } > + > do_random_tests (); > do_page_tests (); > do_page_2_tests (); > -- > 2.31.1 >