From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 77D783858D3C for ; Mon, 8 Nov 2021 19:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77D783858D3C Received: by mail-pf1-x42a.google.com with SMTP id 127so17058551pfu.1 for ; Mon, 08 Nov 2021 11:43:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OfyYrKXnlEpFTSrCt7Qu0iK7B2YN9q/fhfMvVQvN5hg=; b=axRP9GatJLIxOy5QLXtj3hOMzteQCWq4woPIDPsXnXvoyh0WWqjpWSERO89nI1B3dE uUHVJg0/4fZTm2TgNU5v6sOvmcfVdmboEepXg8E4Dl0RIOcCuLh6CKp0PVHZD0/EHfWl pDckuxXhGmqnMi1Hgb77H8rH7zpqdoc/hCb3MGAINZZB9g3Cx3d0s/nfkKO6lkmiKAqY EXrTE3FKNWp/Thn1eObd37N3t66z3vvue0hYOLVvS4G8jonZ08/To3Zynr9AqS9NCxo/ hTuN0GomrO2TP8feMc/+6kQ5RL0KBmcZ2WRRkNJet6spZeWO8bZxF1tzfy3KGMumSnFb JX+Q== X-Gm-Message-State: AOAM532lZHQht68Ma95U6x53bm4ieEAMzJqf/ENV91wUgDWAauWa56x8 0LlEB/eoVAvmVyLFvUhHprWpIi6zWmT3W0wZebA6DXuiNdI= X-Google-Smtp-Source: ABdhPJyoU6Vvjy+fEn4o0Lt95sYbQQbBOEaAjSMnHIOjJJ45symCg1GKPCerPCTv/lHE3mvwdfwmtvQsmwPzO9UZy2Q= X-Received: by 2002:a62:8c55:0:b0:49f:df22:c4ca with SMTP id m82-20020a628c55000000b0049fdf22c4camr1710522pfd.11.1636400611595; Mon, 08 Nov 2021 11:43:31 -0800 (PST) MIME-Version: 1.0 References: <20211107160829.1004634-1-hjl.tools@gmail.com> <2e15794f-555c-30f1-f774-f23839146da6@linaro.org> In-Reply-To: From: Noah Goldstein Date: Mon, 8 Nov 2021 13:43:21 -0600 Message-ID: Subject: Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60) To: "H.J. Lu" Cc: Adhemerval Zanella , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 19:43:34 -0000 On Mon, Nov 8, 2021 at 8:02 AM Noah Goldstein wrote: > > On Mon, Nov 8, 2021 at 7:14 AM H.J. Lu via Libc-alpha > wrote: > > > > On Mon, Nov 8, 2021 at 3:39 AM Adhemerval Zanella > > wrote: > > > > > > > > > > > > On 07/11/2021 13:08, H.J. Lu via Libc-alpha wrote: > > > > commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a > > > > Author: Noah Goldstein > > > > Date: Mon Nov 1 00:49:48 2021 -0500 > > > > > > > > string: Make tests birdirectional test-memcpy.c > > > > > > > > This commit updates the memcpy tests to test both dst > src and dst < > > > > src. This is because there is logic in the code based on the > > > > > > > > Signed-off-by: Noah Goldstein > > > > Reviewed-by: H.J. Lu > > > > > > > > significantly increased the number of tests. On Intel Core i7-1165G7, > > > > test-memcpy takes 120 seconds to run when machine is idle. Double > > > > TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is > > > > under heavy load. > > > > > > Shouldn't we split the test instead? If it takes 120s on a high-end chip, > > > it might take way more in other chips. It also optimizes the testsuite, > > > since it would allow to better use parallel builds. > > > > This sounds like a good idea. Noah, can you do that? The reality is 95% of the extra test time is from the additional large memcpy tests in `#ifdef DO_EXTRA_TESTS` region. Not sure there is really any value in making a seperate test for them as I think the runtime would still require the larger timeout. Do we still want it? Alternatively I could cut out some of the tests. > > Yeah. > > > > > Thanks. > > > > > > --- > > > > string/test-memcpy.c | 1 + > > > > string/test-string.h | 4 +++- > > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/string/test-memcpy.c b/string/test-memcpy.c > > > > index 3b0f3127b7..101d51c487 100644 > > > > --- a/string/test-memcpy.c > > > > +++ b/string/test-memcpy.c > > > > @@ -22,6 +22,7 @@ > > > > # define MIN_PAGE_SIZE 131072 > > > > # define TEST_MAIN > > > > # define TEST_NAME "memcpy" > > > > +# define TIMEOUT (8 * 60) > > > > # include "test-string.h" > > > > > > > > char *simple_memcpy (char *, const char *, size_t); > > > > diff --git a/string/test-string.h b/string/test-string.h > > > > index 8ee00a04b1..9a6b76daa4 100644 > > > > --- a/string/test-string.h > > > > +++ b/string/test-string.h > > > > @@ -68,7 +68,9 @@ extern impl_t __start_impls[], __stop_impls[]; > > > > > > > > > > > > # define TEST_FUNCTION test_main > > > > -# define TIMEOUT (4 * 60) > > > > +# ifndef TIMEOUT > > > > +# define TIMEOUT (4 * 60) > > > > +# endif > > > > # define OPT_ITERATIONS 10000 > > > > # define OPT_RANDOM 10001 > > > > # define OPT_SEED 10002 > > > > > > > > > > > > -- > > H.J.