From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by sourceware.org (Postfix) with ESMTPS id 68493386C5A3 for ; Thu, 30 Jun 2022 03:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68493386C5A3 Received: by mail-yb1-xb2c.google.com with SMTP id v185so21919893ybe.8 for ; Wed, 29 Jun 2022 20:10:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UMc34UqfrbajFqWeTSK2ZzhpA+9LqmkLrUdJzdxoYeE=; b=CficFo1WNGwulntq/M1BULMQ2s5KPhchc8aoz/WhgVVqiNdWJRO5rSrAhIYiSbHsT7 D8MicaeVZ3Hu3Ha/W+2A8RCCdmVBWhQWmExULGlUheQ+P0pmfS4MeCNEb1zBD/Txoz3U Qj1PRbBY8/Ya3S1L17CrKCtRH1sZy14svkMZfFRBUzT8S8BQPyvOsWdD5Y36qipRMOzU XMp2BfjwTiuncGSsSiihiXQZlLosHZ04EnODROQ2vIQu7yYs5xVgDQLz0onPm6xY3m6T E3d5bZ6cDTty9hsaOwWfgbQe6Ojthu1qSbtJ5J4k3J6kfAWwEuWKbWMzF0Py4x0+qXVr EtWg== X-Gm-Message-State: AJIora8hIMbFiiEMVt5u2QX3oa3SfVytKrmwsVaMzteF+7+lVoxlhSRx I/IkeoH2UHHrt4JrjtVmMgXXmyhxVC3I7QZIu75zL8kcm/k= X-Google-Smtp-Source: AGRyM1tia47WQBHcn0hjt4kCXeGxE7dji6ygflJxwobo1oxLVhMXf3WBjiA7EVPFN8FLmRHBAwgFStXZYTUOjham9EQ= X-Received: by 2002:a25:d1c4:0:b0:66d:7802:17da with SMTP id i187-20020a25d1c4000000b0066d780217damr5513013ybg.435.1656558613699; Wed, 29 Jun 2022 20:10:13 -0700 (PDT) MIME-Version: 1.0 References: <20220628152717.17838-1-goldstein.w.n@gmail.com> <20220630030838.3693807-1-goldstein.w.n@gmail.com> In-Reply-To: <20220630030838.3693807-1-goldstein.w.n@gmail.com> From: Noah Goldstein Date: Wed, 29 Jun 2022 20:10:03 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 03:10:15 -0000 On Wed, Jun 29, 2022 at 8:08 PM Noah Goldstein wrote: > > Was missing to for the multiarch build rtld-strncmp-sse4_2.os was > being built and exporting symbols: > > build/glibc/string/rtld-strncmp-sse4_2.os: > 0000000000000000 T __strncmp_sse42 > > Introduced in: > > commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a > Author: H.J. Lu > Date: Wed Jun 21 12:10:50 2017 -0700 > > x86-64: Implement strcmp family IFUNC selectors in C > --- > sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > index 9773e5fc09..310a6dbe77 100644 > --- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > +++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S > @@ -16,6 +16,8 @@ > License along with the GNU C Library; if not, see > . */ > > -#define STRCMP_SSE42 __strncmp_sse42 > -#define USE_AS_STRNCMP > -#include "strcmp-sse42.S" > +#if IS_IN (libc) > +# define STRCMP_SSE42 __strncmp_sse42 > +# define USE_AS_STRNCMP > +# include "strcmp-sse42.S" > +#endif > -- > 2.34.1 > Ignore this patch