From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 311F13858D39 for ; Tue, 2 Nov 2021 16:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 311F13858D39 Received: by mail-pl1-x62b.google.com with SMTP id k4so7290502plx.8 for ; Tue, 02 Nov 2021 09:31:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a2aar0GkpxYXyw7HxHawBwsZrnXtzNKXcjmWj/jGIt4=; b=YD6mASGCRHUpRmufkfCbMh/YkaWH0aEBayBekw5CrnAjH0Zn0l3KyCANVgHJgg3SSI SZWYDPoYVNsHcsCau1oh2WfFuHYzBnjHHk97ZpTwE7hKO7q0n+maLO/v+cEYYAl278uy 6REubwunMWjmlz/bLeVX/rMkm2h2kFvH9sP5wYnGexhHiRAYDpPIPt6Z+KZPcNE/1SeU 06pOkYsOGej/LWICR2GdNe3vfTmZyGZlRVvUDASeVfcjwg96wZXYcWahFEsq0Dh5Ja2R FjjT9WBxK2KypCx/pJINKQWuCXbwBDTtiV7mHt3rb/7Mz5B4kP0N5v+z5e9dHtTa7rMF W9qA== X-Gm-Message-State: AOAM5305XAaOAD+/161ZZAHpnu45H4vNF55NpeAabKpfVgyhTIUTd9IV lB/gHAO6Q/HMW6a2KpNgxqUilpfHDRIPtggWTAw4Uuin X-Google-Smtp-Source: ABdhPJxvfltI/37fHbDKABdfAX8P9evCPZjDUgJIoF/juaIW9qcNrQAMuIU5Dz/MGD5B+13uaYlB+5YkzqE2wt8NM6M= X-Received: by 2002:a17:902:f544:b0:141:b70e:202 with SMTP id h4-20020a170902f54400b00141b70e0202mr24553019plf.0.1635870688315; Tue, 02 Nov 2021 09:31:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noah Goldstein Date: Tue, 2 Nov 2021 11:31:18 -0500 Message-ID: Subject: Re: Monday Patch Queue Review update (2021-11-01) To: "Carlos O'Donell" Cc: libc-alpha , Patrick McGehearty Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 16:31:31 -0000 On Tue, Nov 2, 2021 at 11:19 AM Carlos O'Donell wrote: > > On 11/1/21 23:19, Noah Goldstein wrote: > > On Mon, Nov 1, 2021 at 9:26 PM Carlos O'Donell via Libc-alpha > > wrote: > >> > >> Most recent meeting status is always here: > >> https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update > >> > >> Meeting: 2021-11-01 @ 0900h EST5EDT > >> > >> Video/Audio: https://bluejeans.com/9093064454 > >> > >> IRC: #glibc on OFTC. > >> > >> Review new patches and restart review at the top. > >> > >> * State NEW, Delegate NOBODY, 317 patches. > >> * Series 4330: Enable EVEX strcmp > >> * Carlos noted that with Noah and HJ working together this is enough review > >> along with the microbenchmark to commit this code. > >> * Series 4329: Fix lld build for armhf > >> * HJ: Binary with ARM_EXIDX inbetween to relocation sections looks odd. > >> * We fixed a similar issue with fa19d5c48a6b36518ce68412e3bdde6bfa8aa4a6. > >> * Rewrite as cleanup and provide timing cycle information. > >> * Series 4318: [v1,1/5] string: Make tests birdirectional test-memcpy.c > >> * HJ to review. > >> * Series 4294: benchtests: Add atan2f, expm1f, log1pf and tanf to bench-math (4 patches) > >> * Series 4292: benchtests: Add float version of math functions to bench-math (12 patches) > >> * Convert double input to float input. > >> * Series 4208: regex: Unnest nested functions in regcomp.c > >> * Carlos to look at it. > >> * 46656: [PiNg,9] localedata: add new locale ab_GE > >> * 46551: powerpc: Use the correct flag for 32-bit known libraries > >> * Needs a new commit message. > >> * 46481: manual: remove an obsolete requirement on aligned_alloc() usage > >> * Status? Suggest version the interface, return error without alignment. > >> * Enable hard-coded path in tests. > >> * 46294: elf: Also try DT_RUNPATH for internal dlopen [BZ #28455] > >> * 46295: Add and use link-test-modules-rpath-link [BZ #28455] > >> * Carlos to review. > >> * Series 2732: malloc: Improve Huge Page support > >> * Maxim Kuvyrkov attended. Hello Maxim! > >> * Linaro looking at benchmarking toolchains. > >> * Patrick: libmicro has many mirobenchmarks. > >> * Stream benchmarks were showing regression for the L3 memcpy issue we fixed before. > > > > Any bugzilla for this? Don't see one. > > No, it was commit d3c57027470b78dba79c6d931e4e409b1fecfc80 > > Let me expand on this. > > Maxim at the meeting asked if there were benchmarks they could add to their CI/CD benchmark program. > > Maxim was looking for benchmarks that had previously caught performance problems. > > Patrick McGehearty noted that the x86 memcpy issue related to L3 usage was caught downstream. > > It was caught downstream by running stream and seeing a performance regression. > > The fix is already in glibc. > > Maxim was going to look at stream as a performance benchmark that has visibly observed a regression. > > Does that answer your question? Got it. Thought there was an active regression in head or 2.34 release > > >> * It is very important that you must find the patch that makes the change. > >> * We are doing post-commit testing. > >> * Pre-commit testing is the point where it is easiest to prevent a patch going. > >> > >> -- > >> Cheers, > >> Carlos. > >> > > > > > -- > Cheers, > Carlos. >