From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [IPv6:2a00:1450:4864:20::12f])
 by sourceware.org (Postfix) with ESMTPS id 545663858D20
 for <libc-alpha@sourceware.org>; Tue, 15 Feb 2022 13:37:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 545663858D20
Received: by mail-lf1-x12f.google.com with SMTP id o2so36948959lfd.1
 for <libc-alpha@sourceware.org>; Tue, 15 Feb 2022 05:37:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=zpTU8mCr2NgXkLvjAIU6i3TxNgMkYpYLOUcj0+DDZRI=;
 b=l71BJKR5yQ19MVz/RRHSZrVZb2Bn/Bn1SHC9cRaPM7QMGwC2CqPDzKWXY5yYwH1PWp
 ttgCBUBvZ70CPLugmaF7ZcMt+HHiIRPxDHaig0OtQffedM441Sqn0UNWy5DJ+0mmNjLv
 AUnDnjIscbUhWuc/Ormqw4Eb2AbcLFnXfc5IHo/EJ71v65r5470tbTlL+6nXERT2m7fq
 udGK94P3hK7CsB8HdsAy8cwCOQjOM80rITea/nCFsPjGHLVh84hNE/vjdyLDZzt3VuwB
 xUYB5SEa1iSKBlMcFY8Bvq082dzffuq32Nndzgiu79Hbo6gaifd6xsb4bIZKURWOszyO
 PV0A==
X-Gm-Message-State: AOAM530tqM8ZLyWfmRvggC4Ic7ffYTB2UJqYoqpO1fg039I4zukC62lJ
 k7Gf1+Jhs512YLg3THuVBpOYTVXE41n2qJlCMl17sacyX0c=
X-Google-Smtp-Source: ABdhPJwi463qcfSyTTP5Tqqm6ax86jRJvqA70LbQE0g5JQiihLp0pthVMY77eFlPjEGgmxaGKjnxDWOSe2RTZjK/vsg=
X-Received: by 2002:a05:6512:234c:: with SMTP id
 p12mr2991280lfu.579.1644932257276; 
 Tue, 15 Feb 2022 05:37:37 -0800 (PST)
MIME-Version: 1.0
References: <20220109122946.2754917-1-goldstein.w.n@gmail.com>
 <20220110213540.1258344-1-goldstein.w.n@gmail.com>
 <20220110213540.1258344-5-goldstein.w.n@gmail.com>
 <87ilthv8s9.fsf@igel.home>
 <CAMe9rOqc--V14JH4CbKkcx-TTi2t2ZibtR1+Kuyj9WdGsaLazg@mail.gmail.com>
 <87y22dtg19.fsf@igel.home>
 <CAMe9rOprvuGM7SpD5KLjK4yzbK4v+gMVt6=z+QsdyeYZkD5AhQ@mail.gmail.com>
 <87tud1tf5d.fsf@igel.home>
 <CAMe9rOoKCD9LTb0FsC-cw3vVkAsTVuFt0aD3UkhVUGe4qoK_jA@mail.gmail.com>
 <CAMe9rOrAmD_KrbBOXuUYQWYC=o9rrJM=4hmg8rECBYfML4Qw7g@mail.gmail.com>
 <87czjomgqn.fsf@igel.home>
 <CAFUsyfKkkn6uy-WKR=9NU8qJ9RR=fV3v=-X8bU0sqzb96vz6hw@mail.gmail.com>
 <CAFUsyfJi8MZGDnmhmy8gyg-tVkCi12saobT59qukP2Nw3jD0gw@mail.gmail.com>
 <CAFUsyfLK4UijysRnYZwUXWOt5E4TVqVo4tKx-mJjUj=W8yoV7w@mail.gmail.com>
In-Reply-To: <CAFUsyfLK4UijysRnYZwUXWOt5E4TVqVo4tKx-mJjUj=W8yoV7w@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Tue, 15 Feb 2022 07:37:26 -0600
Message-ID: <CAFUsyfLtQcnUv9eOMEvc2qBoukVG5WQYLtgb7s0Ojy4z48HkDg@mail.gmail.com>
Subject: Re: [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Sunil K Pandey <skpgkp2@gmail.com>, 
 Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Feb 2022 13:37:40 -0000

On Tue, Feb 15, 2022 at 7:32 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Tue, Feb 15, 2022 at 7:09 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Tue, Feb 15, 2022 at 6:58 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Tue, Feb 15, 2022 at 6:55 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> > > >
> > > > #0  0x00007f4fd4a61df3 in __strncmp_avx2_w (a=0x55aaa1906ffa "tst-tlsmod%",
> > > >     b=0x55aaa1940fed "tst-tls-manydynamic73mod", c=10)
> > > >     at ../sysdeps/x86_64/multiarch/strncmp-avx2_w.c:11
> > > > 11        if (n1 != n2) asm("hlt");
> > >
> > > I'll check that input thanks!
> > >
> > > One thing, your check has some false positives as all that matters is
> > > n1 / n2 have
> > > same zero/non-zero status or same sign.
> >
> > Confirmed. Sorry for the bug, will ping back when fix is up.
>
> Found a bug (hopefully the bug) in strncmp. Did you see this at all
> in strcmp-avx2 or was it just the commit you were referencing?

Made bugzilla for the one I found at least:
https://sourceware.org/bugzilla/show_bug.cgi?id=28895
> > > >
> > > > --
> > > > Andreas Schwab, schwab@linux-m68k.org
> > > > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> > > > "And now for something completely different."