From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 4475A3858D3C for ; Mon, 27 Sep 2021 16:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4475A3858D3C Received: by mail-pg1-x52b.google.com with SMTP id y186so6886629pgd.0 for ; Mon, 27 Sep 2021 09:07:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O2V4HvoGYkL5Yw2UPyfYJ5SfPk7GM6NEmyilhCW8BNo=; b=6EY8hpV8fQdAFM120rP893pgT4ecprlef47LkeDxDMIfxVuCo/Hf6Zed8P2IdB8emw 0lo7a8cyKrLEgpimNFmHDLyuoiLtz4umH/9wKArlLLYd7v//IwhQ467UxTjtZK7m9lDi AUhnxneB6F4FIYDbayQ8PG3ySWbokHR8cu+CuvjANf6Heub2JShIXI12jljwZvsTT3Y1 JIPRF74hnGNOfAQNyU62Pa6l1gTVWff9wCt1lsKy7kks6ikXimnW0RpfFJNWxaMiaFdK dIIqL4Dib1VHQ+qMLRD4IL5R8E4W2FBrO43VgbhEa6DGjsyCbZ1WtA0oqxjQUaPdCp9A dbGg== X-Gm-Message-State: AOAM532D4VuCTjnAKjufiiGJwTrLvgryQKUoFxc1PyjcgiAnHO5icepl mT3eYiNbd31vZbhL7OjfxTdHJRJ05blQ7oYZL9rZZOnW X-Google-Smtp-Source: ABdhPJz5jX1UKJUbgqXYSIfz/FWNspwAZTJl+tbld1q54cSVf1gthBNBNNZh7tlXeMIUvkTjgRbLAZiHFFlIpPfIYHg= X-Received: by 2002:a63:798f:: with SMTP id u137mr366006pgc.321.1632758839832; Mon, 27 Sep 2021 09:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> <20210926205306.900081-2-goldstein.w.n@gmail.com> In-Reply-To: <20210926205306.900081-2-goldstein.w.n@gmail.com> From: Noah Goldstein Date: Mon, 27 Sep 2021 11:07:09 -0500 Message-ID: Subject: Re: [PATCH v1 2/3] x86: Modify ENTRY in sysdep.h so that p2align can be specified To: GNU C Library X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 16:07:23 -0000 On Sun, Sep 26, 2021 at 3:53 PM Noah Goldstein wrote: > No bug. > > This change adds a new macro ENTRY_P2ALIGN which takes a second > argument, log2 of the desired function alignment. > > The old ENTRY(name) macro is just ENTRY_P2ALIGN(name, 4) so this > doesn't affect any existing functionality. > > Signed-off-by: Noah Goldstein > --- > Note this is a duplicate of: > [v2,1/2] x86: Modify ENTRY in sysdep.h so that p2align can be specified > > https://patchwork.sourceware.org/project/glibc/patch/20210922051657.1655745-1-goldstein.w.n@gmail.com/ > > sysdeps/x86/sysdep.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h > index cac1d762fb..937180c1bd 100644 > --- a/sysdeps/x86/sysdep.h > +++ b/sysdeps/x86/sysdep.h > @@ -78,15 +78,18 @@ enum cf_protection_level > #define ASM_SIZE_DIRECTIVE(name) .size name,.-name; > > /* Define an entry point visible from C. */ > -#define ENTRY(name) > \ > +#define ENTRY_P2ALIGN(name, alignment) > \ > .globl C_SYMBOL_NAME(name); > \ > .type C_SYMBOL_NAME(name),@function; > \ > - .align ALIGNARG(4); > \ > + .align ALIGNARG(alignment); > \ > C_LABEL(name) > \ > cfi_startproc; > \ > _CET_ENDBR; > \ > CALL_MCOUNT > > +/* Common entry 16 byte aligns. */ > +#define ENTRY(name) ENTRY_P2ALIGN (name, 4) > + > #undef END > #define END(name) > \ > cfi_endproc; > \ > -- > 2.25.1 > > ping