* [PATCH][aarch64] fix inline asm clobber list in tls-macros.h
@ 2015-03-05 10:12 Szabolcs Nagy
2015-05-13 9:36 ` Szabolcs Nagy
2015-05-13 14:46 ` Marcus Shawcroft
0 siblings, 2 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2015-03-05 10:12 UTC (permalink / raw)
To: libc-alpha; +Cc: Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
AArch64 TLS_GD macro calls __tlsget_addr from inline asm, because
the exact TLS instruction sequence matters, but cc was not on the
clobber list so elf/tst-tlsmod2.so was miscompiled and thus
elf/tst-tls4 and elf/tst-tls-dlinfo tests failed.
It seems tls-macros.h is only used in tests.
Is this patch ok?
Changelog:
2015-03-05 Szabolcs Nagy <szabolcs.nagy@arm.com>
* sysdeps/aarch64/tls-macros.h (TLS_GD): Add "cc" to the clobber list.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: glibc-tls-macros.diff --]
[-- Type: text/x-patch; name=glibc-tls-macros.diff, Size: 463 bytes --]
diff --git a/sysdeps/aarch64/tls-macros.h b/sysdeps/aarch64/tls-macros.h
index 07d02eb..8142185 100644
--- a/sysdeps/aarch64/tls-macros.h
+++ b/sysdeps/aarch64/tls-macros.h
@@ -29,7 +29,7 @@
: "x1", "x2", "x3", "x4", "x5", "x6", \
"x7", "x8", "x9", "x10", "x11", "x12", \
"x13", "x14", "x15", "x16", "x17", "x18", \
- "x30", "memory"); \
+ "x30", "memory", "cc"); \
(int *) (__result); })
#define TLS_IE(x) \
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][aarch64] fix inline asm clobber list in tls-macros.h
2015-03-05 10:12 [PATCH][aarch64] fix inline asm clobber list in tls-macros.h Szabolcs Nagy
@ 2015-05-13 9:36 ` Szabolcs Nagy
2015-05-13 14:46 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2015-05-13 9:36 UTC (permalink / raw)
To: libc-alpha; +Cc: Marcus Shawcroft
On 05/03/15 10:12, Szabolcs Nagy wrote:
> AArch64 TLS_GD macro calls __tlsget_addr from inline asm, because
> the exact TLS instruction sequence matters, but cc was not on the
> clobber list so elf/tst-tlsmod2.so was miscompiled and thus
> elf/tst-tls4 and elf/tst-tls-dlinfo tests failed.
>
> It seems tls-macros.h is only used in tests.
> Is this patch ok?
>
ping
> Changelog:
>
> 2015-03-05 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/aarch64/tls-macros.h (TLS_GD): Add "cc" to the clobber list.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][aarch64] fix inline asm clobber list in tls-macros.h
2015-03-05 10:12 [PATCH][aarch64] fix inline asm clobber list in tls-macros.h Szabolcs Nagy
2015-05-13 9:36 ` Szabolcs Nagy
@ 2015-05-13 14:46 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: Marcus Shawcroft @ 2015-05-13 14:46 UTC (permalink / raw)
To: Szabolcs Nagy; +Cc: GNU C Library
On 5 March 2015 at 10:12, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> AArch64 TLS_GD macro calls __tlsget_addr from inline asm, because
> the exact TLS instruction sequence matters, but cc was not on the
> clobber list so elf/tst-tlsmod2.so was miscompiled and thus
> elf/tst-tls4 and elf/tst-tls-dlinfo tests failed.
>
> It seems tls-macros.h is only used in tests.
> Is this patch ok?
>
> Changelog:
>
> 2015-03-05 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/aarch64/tls-macros.h (TLS_GD): Add "cc" to the clobber list.
OK and committed for you.
/Marcus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-13 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 10:12 [PATCH][aarch64] fix inline asm clobber list in tls-macros.h Szabolcs Nagy
2015-05-13 9:36 ` Szabolcs Nagy
2015-05-13 14:46 ` Marcus Shawcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).