[PATCH][AARCH64][2.19] Backporting "End frame record chain correctly"

[PATCH][AARCH64][2.19] Backporting "End frame record chain correctly"

[Renlin Li]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi all,

This is a backport for branch/release/2.19/master of the patch "End 
frame record chain correctly"  posted in: 
https://sourceware.org/ml/libc-alpha/2014-11/msg00167.html

aarch64-none-linux-gnu target has been tested on the model. No new issues.

Okay to commit?

ChangeLog:

2014-11-11  Renlin Li <Renlin.Li@arm.com>

     [BZ #17555]
     * ports/sysdeps/aarch64/start.S (_start): Delete x29 overwritten 
assignment.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 2-19.diff --]
[-- Type: text/x-patch; name=2-19.diff, Size: 869 bytes --]

diff --git a/NEWS b/NEWS
index 4e722f7..d74f4a6 100644
--- a/NEWS
+++ b/NEWS
@@ -10,7 +10,7 @@ Version 2.19.1
 * The following bugs are resolved with this release:
 
   15946, 16545, 16574, 16623, 16695, 16878, 16882, 16885, 16916, 16932,
-  16943, 16958, 17048, 17069, 17137, 17263, 17325.
+  16943, 16958, 17048, 17069, 17137, 17263, 17325, 17555.
 
 * Reverted change of ABI data structures for s390 and s390x:
   On s390 and s390x the size of struct ucontext and jmp_buf was increased in
diff --git a/ports/sysdeps/aarch64/start.S b/ports/sysdeps/aarch64/start.S
index 35d603a..69b45ea 100644
--- a/ports/sysdeps/aarch64/start.S
+++ b/ports/sysdeps/aarch64/start.S
@@ -47,7 +47,6 @@ _start:
 	/* Create an initial frame with 0 LR and FP */
 	mov	x29, #0
 	mov	x30, #0
-	mov	x29, sp
 
 	/* Setup rtld_fini in argument register */
 	mov	x5, x0

Re: [PATCH][AARCH64][2.19] Backporting "End frame record chain correctly"

[Allan McRae]

On 12/11/14 00:07, Renlin Li wrote:
> Hi all,
> 
> This is a backport for branch/release/2.19/master of the patch "End
> frame record chain correctly"  posted in:
> https://sourceware.org/ml/libc-alpha/2014-11/msg00167.html
> 
> aarch64-none-linux-gnu target has been tested on the model. No new issues.
> 
> Okay to commit?
> 
> ChangeLog:
> 
> 2014-11-11  Renlin Li <Renlin.Li@arm.com>
> 
>     [BZ #17555]
>     * ports/sysdeps/aarch64/start.S (_start): Delete x29 overwritten
> assignment.

OK

Re: [PATCH][AARCH64][2.19] Backporting "End frame record chain correctly"

[Marcus Shawcroft]

On 11 November 2014 14:07, Renlin Li <renlin.li@arm.com> wrote:
> Hi all,
>
> This is a backport for branch/release/2.19/master of the patch "End frame
> record chain correctly"  posted in:
> https://sourceware.org/ml/libc-alpha/2014-11/msg00167.html
>
> aarch64-none-linux-gnu target has been tested on the model. No new issues.
>
> Okay to commit?
>
> ChangeLog:
>
> 2014-11-11  Renlin Li <Renlin.Li@arm.com>
>
>     [BZ #17555]
>     * ports/sysdeps/aarch64/start.S (_start): Delete x29 overwritten
> assignment.

Committed.  /Marcus