From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24944 invoked by alias); 21 Nov 2014 14:32:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24909 invoked by uid 89); 21 Nov 2014 14:32:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f46.google.com MIME-Version: 1.0 X-Received: by 10.224.79.136 with SMTP id p8mr7181704qak.70.1416580319228; Fri, 21 Nov 2014 06:31:59 -0800 (PST) In-Reply-To: <1416329010-8683-2-git-send-email-will.newton@linaro.org> References: <1416329010-8683-1-git-send-email-will.newton@linaro.org> <1416329010-8683-2-git-send-email-will.newton@linaro.org> Date: Fri, 21 Nov 2014 14:32:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] AArch64: Update relocations for ILP32 From: Marcus Shawcroft To: Will Newton Cc: GNU C Library Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-11/txt/msg00596.txt.bz2 On 18 November 2014 16:43, Will Newton wrote: > The latest version of the binutils ELF header defines a new set of > dynamic relocations for ILP32 and renames some to make the naming > more uniform. > > ChangeLog: > > 2014-11-18 Will Newton > Andrew Pinski > > * elf/elf.h (R_AARCH64_P32_ABS32, R_AARCH64_P32_COPY, > R_AARCH64_P32_GLOB_DAT, R_AARCH64_P32_JUMP_SLOT, > R_AARCH64_P32_RELATIVE, R_AARCH64_P32_TLS_DTPMOD, > R_AARCH64_P32_TLS_DTPREL, R_AARCH64_P32_TLS_TPREL, > R_AARCH64_P32_TLSDESC, R_AARCH64_P32_IRELATIVE): Define. > (R_AARCH64_TLS_DTPMOD64): Rename to .. > (R_AARCH64_TLS_DTPMOD): This. > (R_AARCH64_TLS_DTPREL64): Rename to ... > (R_AARCH64_TLS_DTPREL): This. > (R_AARCH64_TLS_TPREL64): Rename to ... > (R_AARCH64_TLS_TPREL): This. > * sysdeps/aarch64/dl-machine.h (elf_machine_type_class): Update > R_AARCH64_TLS_DTPMOD64, R_AARCH64_TLS_DTPREL64, and > R_AARCH64_TLS_TPREL64. > (elf_machine_rela): Likewise. > --- > elf/elf.h | 20 +++++++++++++++++--- > sysdeps/aarch64/dl-machine.h | 12 ++++++------ > 2 files changed, 23 insertions(+), 9 deletions(-) > > diff --git a/elf/elf.h b/elf/elf.h > index 78815e8..d752343 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -2362,6 +2362,20 @@ typedef Elf32_Addr Elf32_Conflict; > /* AArch64 relocs. */ > > #define R_AARCH64_NONE 0 /* No relocation. */ > + > +/* ILP32 AARCH64 relocs. */ Nit, AArch32 and double space after period. > +#define R_AARCH64_P32_ABS32 1 /* Direct 32 bit. */ > +#define R_AARCH64_P32_COPY 180 /* Copy symbol at runtime. */ > +#define R_AARCH64_P32_GLOB_DAT 181 /* Create GOT entry. */ > +#define R_AARCH64_P32_JUMP_SLOT 182 /* Create PLT entry. */ > +#define R_AARCH64_P32_RELATIVE 183 /* Adjust by program base. */ > +#define R_AARCH64_P32_TLS_DTPMOD 184 /* Module number, 32 bit. */ > +#define R_AARCH64_P32_TLS_DTPREL 185 /* Module-relative offset, 32 bit. */ > +#define R_AARCH64_P32_TLS_TPREL 186 /* TP-relative offset, 32 bit. */ > +#define R_AARCH64_P32_TLSDESC 187 /* TLS Descriptor. */ > +#define R_AARCH64_P32_IRELATIVE 188 /* STT_GNU_IFUNC relocation. */ > + > +/* LP64 AARCH64 relocs. */ Nit AArch64 and double space after period. Oherwise OK /Marcus