From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 483F1385841B for ; Mon, 18 Mar 2024 13:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 483F1385841B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 483F1385841B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710768678; cv=none; b=rp1Nj4sgGqLRKARCumINOvIFw3BXkHyZ4c90tUhZGM/gNPAT1bDUKL6IrsXAD2Zxlv1hayY7g+cPoY+OWRyRcJvFBxvTQ045iH0rE9zBGfxWYcJCua8ND//Ya2k4j4rhD4hljWwa0s5K6GjNV+p6YTLZONp21ydJiKzh3XIkOzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710768678; c=relaxed/simple; bh=IaUhWuot+s82BM+ydjSe8jP0zCPa/iKUhoOHThBpcz4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=bj3s99ral1CtAbN6hMBm69bpkyX1XvxJ94OfXHBFL/M0e8XR/qloZx3YyqebD6Nh5k7eFWZd1p5Gr+uviJCK+Yq9XJfaVfZYMyMzixdPWOD4e3Bnk1eMbMe9eXY5eeTMo4+Yl4rjsbLdbNHiMwWlpWwHweeFRa7U5pr3VuFo4KQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710768675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ezJ9fX5Y0RIixuqX0hPv3h9yMx/NN9HrFaTYG7RJRLM=; b=MhK04CA5DcejKA/Buysvhv/BkK/55dK2Jw5BzMY8cP9XcpckQixHzs/vgzd7tl+VKRfyg9 ImCE2Hxf99jIDSYIgpNdd4f6ucd1vGvgfhTI0A6i5N/9Kefyv1LTZMTyDOQsPov4KOu47n 5l9DhNcf5RO0Zxeb/a3gekW7meoxWJw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-6qVf5-UtN9OfouVimhUWCA-1; Mon, 18 Mar 2024 09:31:13 -0400 X-MC-Unique: 6qVf5-UtN9OfouVimhUWCA-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-29de4f107b7so2871004a91.2 for ; Mon, 18 Mar 2024 06:31:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710768672; x=1711373472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ezJ9fX5Y0RIixuqX0hPv3h9yMx/NN9HrFaTYG7RJRLM=; b=MX2PWZ574NjT7Ye1djR35ttHaz14hdU/X6BXnMCxnE55AGCffyOtwzbb/dXgRJQUNG 6Cv4zUN9YfBRPSntRR2WC3H4rJdlOD145NVWOpc8U9u3yD0txYKaSqBEZhIomNdr8AMN aIai26O+2rTpRiwV4pLrLIXYrOQFNCtz3gWPhAhO95R9qUBeQuF8/Vjoxj/NBqXCnO8o QBPKN55z2Hf+NKbhlxFQPBxiwCWvg2XyLrL/JoLQODbltAwPczqyO0LTo77Q+XBeKr2a Mix4bGx7eTIBFYezDpf4fo247jNbEmM5StPsK5IpCSSGU4tTovHbiCTy/1d5HK9e8dGr 0wDg== X-Forwarded-Encrypted: i=1; AJvYcCUJu6a6EVcNoN6MMddgLY+emIAZNwGQXcnu3+YNjnsOEjzQXfHQxWjuHMJle5oFUqYzzCfmnKoULitewlrJMQLp70AT2eiElqBQ X-Gm-Message-State: AOJu0YzwOW7Y3olWc3e6Fd6CX1NjtJZ34CiqkbkRcCT9dAXLRkYoVL58 klXVB2NpgDM/5Rcng/vUPQCfUeNwppYBq+BH+edfjdImJu5t9ll1iO3b1Aq5EwqnXrJpkoi50F5 mUJcEaP8Gh3hpghSbKypbu0bAqDsjC/cv+TeP2/TXg3r9t1vhW5CVG3Y7B2b4+iL2rumzsByyRi Js4iyCgRPdnTFuMP5d9m79fQrxmE/hPVGK X-Received: by 2002:a17:90a:f405:b0:29d:9c46:a6aa with SMTP id ch5-20020a17090af40500b0029d9c46a6aamr8585210pjb.17.1710768672031; Mon, 18 Mar 2024 06:31:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEb/mrUag+cDexT4HELzRPhx+rwr1HSlx4NKhs0gcJ46qsw9zy+vYJvKhpdR417Tjg597oVntMS0VflF70Kg+4= X-Received: by 2002:a17:90a:f405:b0:29d:9c46:a6aa with SMTP id ch5-20020a17090af40500b0029d9c46a6aamr8585193pjb.17.1710768671774; Mon, 18 Mar 2024 06:31:11 -0700 (PDT) MIME-Version: 1.0 References: <20240313000429.23213-2-palmer@rivosinc.com> In-Reply-To: <20240313000429.23213-2-palmer@rivosinc.com> From: Arjun Shankar Date: Mon, 18 Mar 2024 14:31:00 +0100 Message-ID: Subject: Re: [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations To: Palmer Dabbelt Cc: simon.chopin@canonical.com, "Carlos O'Donell" , libc-alpha@sourceware.org, Andreas Schwab X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I have commit verification turned on by default, which trips up pulling > when there is a non-signed commit at HEAD. There's likely a whole class > of similar configuration issues that could crop up, so this just ignores > user configuration files entirely. > > Signed-off-by: Palmer Dabbelt Looks like this unconditionally sets these environment variables? I'm wondering if this limits other use cases like e.g., users who set these environment variables and expect those values to be used during build-many-glibcs (for whatever reason)? > --- > This has been pretty lightly tested, but it seems to not be breaking > anything on my end. > > Changes since v1 <20240112185846.24483-1-palmer@rivosinc.com/>: > * Ignore the git configs rather than passing "--no-verify-signatures" to > "git pull" commands. > --- > scripts/build-many-glibcs.py | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index cc30dd5862..0d06ca1ba4 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -1976,8 +1976,15 @@ def check_for_required_tools(): > if count_old_tools > 0 or count_missing_tools > 0: > exit (1); > > +def setup_env_vars(): > + # Prevents git from loading configuration files, to avoid tripping over > + # user settings like --verify-signatures. > + os.environ["GIT_CONFIG_GLOBAL"] = "/dev/null" > + os.environ["GIT_CONFIG_NOSYSTEM"] = "1" > + > def main(argv): > """The main entry point.""" > + setup_env_vars(); > check_for_required_tools(); > parser = get_parser() > opts = parser.parse_args(argv) > -- > 2.43.0 > -- Arjun Shankar he/him/his