From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2CDE83858C2C for ; Wed, 22 Dec 2021 13:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CDE83858C2C Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99-TpADGupEMZqHHIfpdxgqtQ-1; Wed, 22 Dec 2021 08:45:19 -0500 X-MC-Unique: TpADGupEMZqHHIfpdxgqtQ-1 Received: by mail-ed1-f69.google.com with SMTP id d7-20020aa7ce07000000b003f84e9b9c2fso1891451edv.3 for ; Wed, 22 Dec 2021 05:45:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H90gkByuuYozr15SRGaCvG5XzhnqD/0fOpbG0lNoz9I=; b=vD/klYXb+jtK3W244SDU6skyg4HkMFba5QwnRVtq6RC0ONujg/CY0r+wUXbJgur4np G8542PtmDYzF1OKBmUw81tkNALvoVMuygQ4z3AF9u1NqwCMp9Jplz0CVwiAMqUAlyNl1 qdCNB9mx02uSnW4XqSzxd83NdEqGNiR0q3lChsilu2MBWn7fKP79rSHujl5jB3VexVVi iv0ioEB/gNSQEobY/ley77UIs4Mciusu7ZenF9KNmmnrCYsCcrblrYfPNk9Bm1FY2LP4 tDogLnYYMVSBC78p/I+FIM8OsSlduifqVPlMXN6BbgTYgtLju1QGPHC3/vd6gd3DMVBa /01w== X-Gm-Message-State: AOAM530Eagl8jX+uKhSB2hnGayfZ5SDFwPk6dF/kH93CHFO3hp7tpDNe haib1pPdI3atqBSwO5KbmzsLJ12fhsyx9Y0yKWjlEdiy3M5EJuNWg6vhcwYfth/dqzx3t9JB0H5 NDQYUUMHWtDVa+B0iLSZEeSGzSd3BeYTR7hdp X-Received: by 2002:a17:907:3ea8:: with SMTP id hs40mr2454985ejc.353.1640180718438; Wed, 22 Dec 2021 05:45:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJygsXS7DBMbzl9A8PFpeR8p5g2pzH/Rxm66DvqyCvuXfk4isbV7wjSkblaLT4+qbdHbwqq4t9Wrj/o6D0P94sE= X-Received: by 2002:a17:907:3ea8:: with SMTP id hs40mr2454970ejc.353.1640180718264; Wed, 22 Dec 2021 05:45:18 -0800 (PST) MIME-Version: 1.0 References: <87lf0dy0n0.fsf@autistici.org> In-Reply-To: <87lf0dy0n0.fsf@autistici.org> From: Arjun Shankar Date: Wed, 22 Dec 2021 14:45:07 +0100 Message-ID: Subject: Re: [PATCH] intl/plural.y: define macros to avoid multiple conflicting declarations of yyerror and yylex To: Andrea Monaco Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Dec 2021 13:45:24 -0000 Hi Andrea, > > I'm trying to reproduce this and have been unable to see these lines > > generated with bison-3.6.4, 3.7.6, and 3.8.2. > > > Mine is gnu bison 3.8. I got the same problem in binutils > (https://lists.gnu.org/archive/html/bug-binutils/2021-11/msg00057.html) > and it was replicated by a person, though we fixed it in a different way. Thanks. I was able to reproduce it with bison-3.8. It looks like it was a transient issue that occurred in bison-3.8 and was fixed by bison-3.8.2. This patch lets glibc successfully build with bison-3.8 installed and is therefore useful. diff --git a/intl/plural.y b/intl/plural.y index e02e74541c..8573b56563 100644 --- a/intl/plural.y +++ b/intl/plural.y @@ -40,6 +40,11 @@ # define __gettextparse PLURAL_PARSE #endif +/* Later we provide those prototypes. Without these macros, bison may + generate its own prototypes with possible conflicts */ +#define YYLEX_IS_DECLARED +#define YYERROR_IS_DECLARED + %} %parse-param {struct parse_args *arg} %lex-param {struct parse_args *arg} OK. glibc uses double spaces at the end of a sentence in comments. It's a minor edit and I'll make it before committing. Reviewed-by: Arjun Shankar