From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4AA97385B51F for ; Mon, 20 Feb 2023 20:03:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4AA97385B51F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676923394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UWqe6rxL6a3HzDmSaEiI0tX9KtrJ4CjgRwS6QyDi3ac=; b=ALi1X0s1iajptCzBg/I4900zKvnB2/RefceCtBV/OAap2vqMgeRHbiztGnoz02qutsh2HC lVaQXR0xb3GdChADlahGc5TIlFe/jCg25JX3BkklHXLgWZjFWqvGO33gnxvaPSt+vcUuuS RbAfaUSA/1+JyHDwFH4boxuaATTVuSY= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-486--dCwdnrPOr-SRpicRJzxEg-1; Mon, 20 Feb 2023 15:03:12 -0500 X-MC-Unique: -dCwdnrPOr-SRpicRJzxEg-1 Received: by mail-oi1-f200.google.com with SMTP id p6-20020acad806000000b0037890be175fso619547oig.14 for ; Mon, 20 Feb 2023 12:03:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UWqe6rxL6a3HzDmSaEiI0tX9KtrJ4CjgRwS6QyDi3ac=; b=Bbnh45mdyswPUr85iQBOzE26en9vjximnhj9LRMC6cFdvxX+4ExnpNt3BzklmW5yu4 EchtuGyEAaSKp3O4MhQWTx/mdl0SdhQWWPg5LYavRr3JoLDX6Tm2/kbaZpPGGnLlI0xN dAgoZfDQ62gDOadFUw6kvDbTHNWLOE3BzzP/gpIlYwy7xiAd8uNJGjqq4mKssGd+RuRU zIDOxUHKA5wtlHCfkD+WXuG02fvOLfEnTq8h2vt2lLZbrj1ymxMDbH2cNfdTqMc4/nAt qlj04xVY+2bB9alBgHUpZlGRTuUMfZUzli62NTQ7xaSpzxlMWqsRk6GbRakZ1heWmQBF P1+A== X-Gm-Message-State: AO0yUKUfKzVh2q1wTcETSzzV4sJqaRvNVbDuDbQh2s+HvqkAEBdM3OAa ZDX2B1IRAs0KRv+o/X1QJf1QetXkDBfXaMbIj6k/3GjsV43u3Y+LfUeGCpFZWfos1fkO1NOHsbB pnsOak4k1jMZyMs+QhgSPD6ujPat1MiOBYivD2KHJByX3 X-Received: by 2002:a05:6870:fb8c:b0:15f:1d8a:8860 with SMTP id kv12-20020a056870fb8c00b0015f1d8a8860mr1330996oab.153.1676923391801; Mon, 20 Feb 2023 12:03:11 -0800 (PST) X-Google-Smtp-Source: AK7set+1qD/m6ud605nzdw78D/CXBAzoI+svokE374Gor3umZ9AwOEK1ylYuR2IUi2uUpRbaiyT4PfoHVZ9l23SPukY= X-Received: by 2002:a05:6870:fb8c:b0:15f:1d8a:8860 with SMTP id kv12-20020a056870fb8c00b0015f1d8a8860mr1330995oab.153.1676923391492; Mon, 20 Feb 2023 12:03:11 -0800 (PST) MIME-Version: 1.0 References: <20230220142356.1180570-1-adhemerval.zanella@linaro.org> In-Reply-To: <20230220142356.1180570-1-adhemerval.zanella@linaro.org> From: Arjun Shankar Date: Mon, 20 Feb 2023 21:03:00 +0100 Message-ID: Subject: Re: [PATCH] s390: Fix build for -march=z13 To: Adhemerval Zanella Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval, > It fixes the build after 7ea510127e2067e and 22999b2f0fb62. > > Checked with build for s390x-linux-gnu with -march=z13. Thanks! This LGTM, and fixes a build failure on master with Fedora Rawhide on s390x (which uses -march=z13). Reviewed-by: Arjun Shankar > --- > sysdeps/s390/memrchr-vx.S | 1 + > sysdeps/s390/strchrnul-vx.S | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/sysdeps/s390/memrchr-vx.S b/sysdeps/s390/memrchr-vx.S > index c6c3168668..4080dccfbc 100644 > --- a/sysdeps/s390/memrchr-vx.S > +++ b/sysdeps/s390/memrchr-vx.S > @@ -161,6 +161,7 @@ ENTRY(MEMRCHR_Z13) > END(MEMRCHR_Z13) > > # if ! HAVE_MEMRCHR_IFUNC > +libc_hidden_def (__memrchr) > strong_alias (MEMRCHR_Z13, __memrchr) > weak_alias (__memrchr, memrchr) > # endif > diff --git a/sysdeps/s390/strchrnul-vx.S b/sysdeps/s390/strchrnul-vx.S > index 07f39426b7..b705979481 100644 > --- a/sysdeps/s390/strchrnul-vx.S > +++ b/sysdeps/s390/strchrnul-vx.S > @@ -94,6 +94,7 @@ ENTRY(STRCHRNUL_Z13) > END(STRCHRNUL_Z13) > > # if ! HAVE_STRCHRNUL_IFUNC > +libc_hidden_def (__strchrnul) > strong_alias (STRCHRNUL_Z13, __strchrnul) > weak_alias (__strchrnul, strchrnul) > # endif > -- > 2.34.1 >