From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AA1ED3858D32 for ; Mon, 29 May 2023 13:35:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA1ED3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685367307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xqyvAHmJVXvuQgtX6X6SbsBE1a/IwjM7ETej4ueQCZo=; b=YtBoqYKbjdxsB4n93BP6rMCyb8ZNCwzUEGdUN+8PV5etYDvWFPCIOyvYchq+uNy/Sv0L6U htCZ1yeJCCmxvFnf9BtPQ4jfBgyARPIA7QLRfY+Pq8zWPZ4PRKdwyXVnB5eWwuVGe96mKO 2g+LRu8CDqIcuJCBooS2OQskk04Qgs4= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-LIh7g-kwNviLRCDPIs6vQA-1; Mon, 29 May 2023 09:35:06 -0400 X-MC-Unique: LIh7g-kwNviLRCDPIs6vQA-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-39809c383deso890389b6e.0 for ; Mon, 29 May 2023 06:35:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685367305; x=1687959305; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xqyvAHmJVXvuQgtX6X6SbsBE1a/IwjM7ETej4ueQCZo=; b=Dwsk5uRNcWGKMPryJ0uLiKlluC+HIFY9OqxOGb+ch+r9ajkOBpgjbtiXEX4L5Shlk1 5MThYIBJPSn6HV9xDsmgnLdkr4qG7Uo+kA1bLpNd/NvoXNSL7bs8SPl1L+ZRGIfkswoZ iEVN0/93nG4tHOkTinL+0iqgbwclj7Jc8Rke79QEmXZnFiBwCfGN7XWnvs+/RfoVLIIa NrQIvKPmlEhjeWhxYBqcII1pB31U4nh/YTdZFifd3PIb5u9MMcSGAhHAy9z1NwKdtwuU zcODKqdu8ndYRBeooNCiG3VtR+AvrKeLIGib4x46m+R+gNxVjHpS0+BPu/yrvy6ThQJM RJiw== X-Gm-Message-State: AC+VfDzPALi1ApmNUHJAhtr1YL4p0zzM+uwNGHO3CtSkt6iMY5QYikAK FRuTfuql6WmAmoDKGiuxKu3KyPa8wluy56lJVL08NanMXVMEqJ2y0MF/Pk5G59iHB85ulXmDv29 /7fJcwDpsawID6YtuwJK8Srf2EoFupMmjBswhtRTfbpTk X-Received: by 2002:a05:6808:8f6:b0:398:12d4:c0c3 with SMTP id d22-20020a05680808f600b0039812d4c0c3mr5062310oic.50.1685367305230; Mon, 29 May 2023 06:35:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7gqXhpPsHVRsX8ds9arX6PdYKcs0PJYtfq2hCWHGKnE/dC0qnNvoHeVPULSZHfonHc9ZUv+sOqiWLk8PkXMeA= X-Received: by 2002:a05:6808:8f6:b0:398:12d4:c0c3 with SMTP id d22-20020a05680808f600b0039812d4c0c3mr5062304oic.50.1685367305023; Mon, 29 May 2023 06:35:05 -0700 (PDT) MIME-Version: 1.0 References: <20230525124503.152721-1-dridi.boukelmoune@gmail.com> In-Reply-To: <20230525124503.152721-1-dridi.boukelmoune@gmail.com> From: Arjun Shankar Date: Mon, 29 May 2023 15:34:53 +0200 Message-ID: Subject: Re: [PATCH glibc] posix: Add error message for EAI_OVERFLOW To: Dridi Boukelmoune Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Signed-off-by: Dridi Boukelmoune > --- > sysdeps/posix/gai_strerror-strs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sysdeps/posix/gai_strerror-strs.h b/sysdeps/posix/gai_strerror-strs.h > index 19040a5138..667c4b2d4a 100644 > --- a/sysdeps/posix/gai_strerror-strs.h > +++ b/sysdeps/posix/gai_strerror-strs.h > @@ -15,3 +15,4 @@ _S(EAI_NOTCANCELED, N_("Request not canceled")) > _S(EAI_ALLDONE, N_("All requests done")) > _S(EAI_INTR, N_("Interrupted by a signal")) > _S(EAI_IDN_ENCODE, N_("Parameter string not correctly encoded")) > +_S(EAI_OVERFLOW, N_("Result too large for supplied buffer")) > -- > 2.40.1 > Thanks! This looks good to me. Reviewed-by: Arjun Shankar ...and I already pushed it!