From: Arjun Shankar <arjun@redhat.com>
To: Andrea Monaco <andrea.monaco@autistici.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] intl/plural.y: define macros to avoid multiple conflicting declarations of yyerror and yylex
Date: Wed, 22 Dec 2021 16:07:23 +0100 [thread overview]
Message-ID: <CAG_osab6K5JTnk=Lpep47z-T9QKa=Yxf6ULnP=NZuWArr2GMng@mail.gmail.com> (raw)
In-Reply-To: <CAG_osaZVg12KRVK2=X7B5311mQCa74b5pbYyjdwQE=y4tB5bAg@mail.gmail.com>
> diff --git a/intl/plural.y b/intl/plural.y
> index e02e74541c..8573b56563 100644
> --- a/intl/plural.y
> +++ b/intl/plural.y
> @@ -40,6 +40,11 @@
> # define __gettextparse PLURAL_PARSE
> #endif
>
> +/* Later we provide those prototypes. Without these macros, bison may
> + generate its own prototypes with possible conflicts */
> +#define YYLEX_IS_DECLARED
> +#define YYERROR_IS_DECLARED
> +
> %}
> %parse-param {struct parse_args *arg}
> %lex-param {struct parse_args *arg}
>
> OK. glibc uses double spaces at the end of a sentence in comments.
> It's a minor edit and I'll make it before committing.
>
> Reviewed-by: Arjun Shankar <arjun@redhat.com>
I have now pushed this to master. I edited the commit message somewhat
after using the one in your original email as a starting point. I hope
it's okay.
Cheers,
Arjun
next prev parent reply other threads:[~2021-12-22 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 23:54 Andrea Monaco
2021-12-22 13:45 ` Arjun Shankar
2021-12-22 15:07 ` Arjun Shankar [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-12 9:24 Andrea Monaco
2021-12-21 22:49 ` Arjun Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_osab6K5JTnk=Lpep47z-T9QKa=Yxf6ULnP=NZuWArr2GMng@mail.gmail.com' \
--to=arjun@redhat.com \
--cc=andrea.monaco@autistici.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).