From: Arjun Shankar <arjun@redhat.com>
To: Joe Simmons-Talbott <josimmon@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] nss: Get rid of alloca usage in makedb's write_output.
Date: Wed, 4 Oct 2023 17:27:42 +0200 [thread overview]
Message-ID: <CAG_osabYhJCnW2bGhy2ztgXTeBOK=zRduLA0=ftsphCwvpv+Gw@mail.gmail.com> (raw)
In-Reply-To: <20231004140001.GH4098455@oak>
> > The way scratch_buffer_init and scratch_buffer_set_array_size are
> > implemented currently, a failure of the set_array_size here looks like
> > it doesn't necessarily need a scratch_buffer_free to be called after
> > failure because there's nothing to be freed. But I think calling
> > scratch_buffer_free here before returning here is the safer bet.
> >
>
> I haven't been including a scratch_buffer_free call on failure of
> scratch_buffer_set_array_size. Both failure code paths for
> scratch_buffer_set_array_size reset the buffer to the default character
> array and any heap allocated storage is freed. If there is agreement
> that a call to scratch_buffer_free is desired I'm happy to add it.
You're right. There is some code that does a free (e.g. an instance in
catgets/gencat.c, and one in nscd/nscd_getgr_r.c via a goto), and some
that does not (e.g. stdio-common/fxprintf.c and
sysdeps/posix/getaddrinfo.c -- which as you said, you've committed
recently).
Reviewed-by: Arjun Shankar <arjun@redhat.com>
Cheers!
--
Arjun Shankar
he/him/his
prev parent reply other threads:[~2023-10-04 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 14:11 Joe Simmons-Talbott
2023-10-04 13:09 ` Arjun Shankar
2023-10-04 14:00 ` Joe Simmons-Talbott
2023-10-04 15:27 ` Arjun Shankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_osabYhJCnW2bGhy2ztgXTeBOK=zRduLA0=ftsphCwvpv+Gw@mail.gmail.com' \
--to=arjun@redhat.com \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).