From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DDB2B3851144 for ; Tue, 28 Jun 2022 17:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDB2B3851144 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-170-eaGOUYxJNnOzeNFS3G4bkA-1; Tue, 28 Jun 2022 13:26:29 -0400 X-MC-Unique: eaGOUYxJNnOzeNFS3G4bkA-1 Received: by mail-ej1-f70.google.com with SMTP id 7-20020a170906310700b007263068d531so3934722ejx.15 for ; Tue, 28 Jun 2022 10:26:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SXW8fA1oGER3G7a2tV1fsT85he9xRjUjhX4API10iqU=; b=UjGaXr/xC0u/R0qrXpuoZ6ZD+S1xnY6WcZUIZqgC52VE/WTmyn7ov2YY/yn6upG9m9 ye86KQcoYGGklQK45lFssCd6AW/gBVaBWswBnxpXmxfy0B4UQWYjnloOfSUT2XDyRt/H 7bMl625byBUQrS4coBXrQ2uuEq2HuYfUAqkr1feiXsofiKab/v32bdiYZHq9LSSOtBXQ ez4v9zCNtGbSBKuLK4akA2M639f7B2rSCBT1KPRcrxs53D4B/4bApaqMGYzwfs44gH1G /aV5htepFNJnFswhEA7nZljtFKoD9v1IFAYKOWwBkJZzda84pLw/mHWcfdmFELDuo/68 2Y3A== X-Gm-Message-State: AJIora+BfOB9WRxSUW1UvdXgMBIsCM1/vcjed+VWQxlgUEHMokJP9zTo cYgfES6KnAU3LjkiwX6blz9VfxReZeFp4TE6o2XQNQ6Bd5m+2pWm3D+UZFk6kv7ZkMDI1ITp0YT NYyNWOEvpgghmjHi/kBTVqTlyaoQKH1ByANw8 X-Received: by 2002:a17:906:7944:b0:6da:b834:2f3e with SMTP id l4-20020a170906794400b006dab8342f3emr18987106ejo.353.1656437188302; Tue, 28 Jun 2022 10:26:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ttVv1e6Xj0LzsDrBSwqzMKzKuJtUDvr/1UKYrn8Kd4sqe7JARMYTcD7oqDbVLqkC85hPH4P56TUzF6jOBk2p0= X-Received: by 2002:a17:906:7944:b0:6da:b834:2f3e with SMTP id l4-20020a170906794400b006dab8342f3emr18987082ejo.353.1656437187997; Tue, 28 Jun 2022 10:26:27 -0700 (PDT) MIME-Version: 1.0 References: <20220426180705.1274657-1-adhemerval.zanella@linaro.org> <20220426180705.1274657-2-adhemerval.zanella@linaro.org> In-Reply-To: <20220426180705.1274657-2-adhemerval.zanella@linaro.org> From: Arjun Shankar Date: Tue, 28 Jun 2022 19:26:17 +0200 Message-ID: Subject: Re: [PATCH 1/2] nptl: Remove unused members from struct pthread To: Adhemerval Zanella Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 17:26:33 -0000 Hi Adhemerval, This looks good to me. Reviewed-by: Arjun Shankar > It removes both pid_ununsed and cpuclock_offset_ununsed, saving about > 12 bytes from struct pthread. > --- > nptl/descr.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/nptl/descr.h b/nptl/descr.h > index bb46b5958e..b5852632e3 100644 > --- a/nptl/descr.h > +++ b/nptl/descr.h > @@ -172,9 +172,6 @@ struct pthread > therefore stack) used' flag. */ > pid_t tid; > > - /* Ununsed. */ > - pid_t pid_ununsed; > - OK. This has been unused since c579f48edba (2016). > /* List of robust mutexes the thread is holding. */ > #if __PTHREAD_MUTEX_HAVE_PREV > void *robust_prev; > @@ -342,10 +339,6 @@ struct pthread > /* Lock for synchronizing setxid calls. */ > unsigned int setxid_futex; > > -#if HP_TIMING_INLINE > - hp_timing_t cpuclock_offset_ununsed; > -#endif > - OK. This has been unused since 38cc11daa43 (2019). > /* If the thread waits to join another one the ID of the latter is > stored here. > > -- > 2.34.1 >