public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Chris Leonard <cjlhomeaddress@gmail.com>
To: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] localedata: CLDRv29: update LC_TIME week/first_week,workday fields
Date: Fri, 22 Apr 2016 19:43:00 -0000	[thread overview]
Message-ID: <CAHdAata7RKXXSLmpFQcrZWuysFo_t6Nnn5jeNnTRhuJbzDFJoA@mail.gmail.com> (raw)
In-Reply-To: <20160422192913.GD5369@vapier.lan>

I can't pretend that I have gone through the details or done any of my
own due diligence, but I am inclined to endorse as a good-faith
effort.  I must admit it feels like a scary large (cross-cutting)
patch and on a field that frequently draws complaints, but I don't
think that an incremental approach would serve any purpose in this
case, so perhaps it is best to just rip off the band-aid all-at-once
and see what happens to people's calendar programs out there.  It
could either cause a big sigh of relief or absolute mayhem for end
users, but I think it is going to be fairly visible, so we should hear
back one way or the other.

cjl

On Fri, Apr 22, 2016 at 3:29 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 16 Apr 2016 03:26, Mike Frysinger wrote:
>> I've spot checked a number of these, including some that were def
>> wrong (like ff_SN).  It also fixes all open week-related bugs.
>>
>> Since ff_SN is the only one that changes its base date, I also made
>> sure that its ordering of day translations were correct.  Looks like
>> another case Petr brought up where the week field was not actually
>> checked against the day arrays.
>>
>> I also took the opportunity to drop first_weekday/first_workday when
>> the value aligned with the defaults (1 & 2 respectively).  This didn't
>> impact too many locales In practice because the majority omitted them
>> already.
>
> any takers on this or the other localedef week patch ? :)
> -mike

  reply	other threads:[~2016-04-22 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-16  7:27 Mike Frysinger
2016-04-22 19:29 ` Mike Frysinger
2016-04-22 19:43   ` Chris Leonard [this message]
2016-04-22 20:33     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHdAata7RKXXSLmpFQcrZWuysFo_t6Nnn5jeNnTRhuJbzDFJoA@mail.gmail.com \
    --to=cjlhomeaddress@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).