From: Hongbo Zhang <hongbo.zhang@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>,
marcus.shawcroft@arm.com, szabolcs.nagy@arm.com,
libc-alpha@sourceware.org
Subject: Re: [PATCH] aarch64: add HXT Phecda core memory operation ifuncs
Date: Tue, 12 Jun 2018 09:57:00 -0000 [thread overview]
Message-ID: <CAHmQWvA1dgti-XB-2cRiiibCH35OFP1FOpECGqK_WOtiJknFBA@mail.gmail.com> (raw)
In-Reply-To: <93d90087-1822-a211-80a8-9aa2089d7a67@redhat.com>
On 12 June 2018 at 17:42, Florian Weimer <fweimer@redhat.com> wrote:
> On 06/12/2018 10:45 AM, Hongbo Zhang wrote:
>>
>> On 12 June 2018 at 14:27, Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>>>
>>> On 06/12/2018 11:25 AM, Hongbo Zhang wrote:
>>>>
>>>>
>>>> Thank you for the quick review.
>>>> It is my first time to upstream a glibc patch, rules seem a bit
>>>> different from kernel/uboot etc.
>>>> If it is up to me to clarify the copyright, how to do it, add a
>>>> Co-authored-by tag?
>>>
>>>
>>>
>>> Yes, the rules are very different from kernel/uboot where the
>>> contributors
>>> continue to own copyright and there's typically only a developer sign-off
>>> to
>>> claim that copyright. In glibc and gcc we have a concept of copyright
>>> assignment where we transfer ownership of code to the Free Software
>>> Foundation who we trust to defend our copyright in case of infringement.
>>>
>>> The problem with the patch is not that of format; you have formatted the
>>> patch perfectly and would have been good to be committed, but we need a
>>> copyright assignment (i.e. an agreement that you're willing to transfer
>>> ownership of the copyright to this code to the FSF) from all authors of
>>> the
>>> patch.
>>>
>>> Your contribution has an automatic assignment since you're a Linaro
>>> assignee, but that's not the case for the other author (AFAICT, again I
>>> don't have access to the copyrights file so I can't tell for sure, only
>>> the
>>> FSF stewards can) because of which we need to understand the scope of
>>> their
>>> contribution and their assignment status to decide on the future course
>>> of
>>> action on this patch.
>>>
>>> Sorry for the trouble, but this is an unavoidable part of the patch
>>> review
>>> workflow.
>>>
>> It is not a trouble, I learned the copyright assignment now, thank you.
>> But as to the exact steps, Shoud Minfeng answer questionnaire like this
>> page?
>> https://www.fsf.org/licensing/assigning.html
>> He never did that before.
>
>
> The forms are linked from here:
>
> <https://sourceware.org/glibc/wiki/Contribution%20checklist#FSF_copyright_Assignment>
>
> For a company, usually someone who has authorization to negotiate and sign
> contracts has to do this, not individual patch authors.
>
> In this case, I think we can still accept the patch because the number of
> lines changes is small (10 lines), but we'd need it for the next patch.
>
Get it, thanks.
> Thanks,
> Florian
next prev parent reply other threads:[~2018-06-12 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 9:46 Hongbo Zhang
2018-06-11 12:34 ` Siddhesh Poyarekar
2018-06-12 5:55 ` Hongbo Zhang
2018-06-12 6:27 ` Siddhesh Poyarekar
2018-06-12 8:46 ` Hongbo Zhang
2018-06-12 9:42 ` Florian Weimer
2018-06-12 9:57 ` Hongbo Zhang [this message]
2018-06-12 10:03 ` Siddhesh Poyarekar
2018-06-12 10:07 ` Siddhesh Poyarekar
2018-06-12 10:17 ` Florian Weimer
2018-06-12 10:28 ` Siddhesh Poyarekar
2018-06-13 7:22 ` Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmQWvA1dgti-XB-2cRiiibCH35OFP1FOpECGqK_WOtiJknFBA@mail.gmail.com \
--to=hongbo.zhang@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=siddhesh@gotplt.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).