From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mxout5.mail.janestreet.com (mxout5.mail.janestreet.com [64.215.233.18]) by sourceware.org (Postfix) with ESMTPS id 25EAD3858C30 for ; Wed, 8 Mar 2023 08:17:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25EAD3858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=janestreet.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=janestreet.com Received: from mail-qt1-f200.google.com ([209.85.160.200]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.96) id 1pZozl-009F0g-1y for libc-alpha@sourceware.org; Wed, 08 Mar 2023 03:17:58 -0500 Received: by mail-qt1-f200.google.com with SMTP id z22-20020ac86b96000000b003bfc3f97097so8683896qts.14 for ; Wed, 08 Mar 2023 00:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1678263478; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IfSHh5P0MdhSvKv3C+wj0U66xJFfM3EfWz2eeMyRH7E=; b=PN5FYYhLZUUVMPs/88xJsqUZz0ZTpfgcFaN3LxFx61kVybMLOeYPSdAEoRAWEkeuEx KF3tKbO+uDqRMNHocLXCbSoGSC41XmeDTJmY1oGsgnU3iZs5Qdy7sUsbAPdudYcRh6tO rKjeSv35p3kIr4aRtUBQGPmRTZYwDFf8A8Be4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678263478; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IfSHh5P0MdhSvKv3C+wj0U66xJFfM3EfWz2eeMyRH7E=; b=e4arsbCBI0z0Ub/HrbvDSWxOgfqmZrJPe3WYj5UgwQEdS70hTxhKup3QVTO94DUnZk amAnwUnR+2RL0Mrg7f+gIOYVqXtCxYynxqpOPI44hZoe7gpTJuzJIt82hWv8DfhzqXm2 O/ox4eVKnmGLOwXBlEgYcHbkNy6sZIuz4JmHwDga8QpzD63lKZVzmqB6b1Nt3mBpd6uH GN7/cL0mcKZto4aZyf6L+P/1SMZFDVtZFzA9BqfAIqPytgOfIbKXaV7sredAljWdjBd5 J0EPAcqR6LKqA5ljIHf5xgE1dWrW472kusShIksZmWbHprQEOR0xGE3rPfh6hoNjsCR3 s6wA== X-Gm-Message-State: AO0yUKXESFQuXvEpIFIJINPuaXvSEg76tkI09InTQ+kJ5NSwaWNbjPEW sXBQ0xdzHkfXmIDnr10VdljFkkfzlOZuFm9Bl4UYu29aqC/cbQKm218eAEEyonhGEy2086RTGvf Qr2XcsSJeNkLCUGpsxfF2EcWgRRv975jbu6g= X-Received: by 2002:ad4:56e1:0:b0:56e:f63b:634e with SMTP id cr1-20020ad456e1000000b0056ef63b634emr4260071qvb.6.1678263478122; Wed, 08 Mar 2023 00:17:58 -0800 (PST) X-Google-Smtp-Source: AK7set+n1B1Zzg0cai7MKmcBcRlNosv4dgLanj9I3mLTZpe3GuMsajkhd4yexygHHpsl65qxbx8t7pB8X4JTaUxqHjg= X-Received: by 2002:ad4:56e1:0:b0:56e:f63b:634e with SMTP id cr1-20020ad456e1000000b0056ef63b634emr4259901qvb.6.1678263477688; Wed, 08 Mar 2023 00:17:57 -0800 (PST) MIME-Version: 1.0 References: <49ed5d3-5752-d91c-42ae-f853cbace1d3@codesourcery.com> In-Reply-To: <49ed5d3-5752-d91c-42ae-f853cbace1d3@codesourcery.com> From: Adam Yi Date: Wed, 8 Mar 2023 16:17:41 +0800 Message-ID: Subject: Re: [PATCH v6] posix: Fix system blocks SIGCHLD erroneously [BZ #30163] To: Joseph Myers Cc: Adhemerval Zanella Netto , libc-alpha@sourceware.org, schwab@suse.de, i@adamyi.com Content-Type: multipart/alternative; boundary="0000000000006d6f7405f65f2a33" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000006d6f7405f65f2a33 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for reporting this! Confirmed that linking with $(shared-thread-library) fixes the problem. I'll send a patch. On Wed, Mar 8, 2023 at 6:50=E2=80=AFAM Joseph Myers wrote: > This breaks the testsuite build for Hurd (tst-system needs to link with > $(shared-thread-library), I think). > > /scratch/jmyers/glibc-bot/install/compilers/i686-gnu/lib/gcc/i686-glibc-g= nu/12.2.1/../../../../i686-glibc-gnu/bin/ld: > /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/support/libsupport_= nonshared.a(xpthread_create.oS): > in function `xpthread_create': > /scratch/jmyers/glibc-bot/src/glibc/support/xpthread_create.c:26: > undefined reference to `pthread_create' > /scratch/jmyers/glibc-bot/install/compilers/i686-gnu/lib/gcc/i686-glibc-g= nu/12.2.1/../../../../i686-glibc-gnu/bin/ld: > /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/support/libsupport_= nonshared.a(xpthread_join.oS): > in function `xpthread_join': > /scratch/jmyers/glibc-bot/src/glibc/support/xpthread_join.c:25: undefined > reference to `pthread_join' > collect2: error: ld returned 1 exit status > make[3]: *** [../Rules:238: > /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/stdlib/tst-system] > Error 1 > > https://sourceware.org/pipermail/libc-testresults/2023q1/010979.html > > -- > Joseph S. Myers > joseph@codesourcery.com > --0000000000006d6f7405f65f2a33--