I haven't signed any FSF paperwork. I'll resend the patch with DCO signoff.
Thanks!

On Tue, Mar 7, 2023 at 8:33 PM Florian Weimer <fweimer@redhat.com> wrote:

> * Adhemerval Zanella Netto:
>
> > On 06/03/23 22:52, Adam Yi wrote:
> >> Fix bug that SIGCHLD is erroneously blocked forever in the following
> >> scenario:
> >>
> >> 1. Thread A calls system but hasn't returned yet
> >> 2. Thread B calls another system but returns
> >>
> >> SIGCHLD would be blocked forever in thread B after its system() returns,
> >> even after the system() in thread A returns.
> >>
> >> Although POSIX does not require, glibc system implementation aims to be
> >> thread and cancellation safe. This bug was introduced in
> >> 5fb7fc96350575c9adb1316833e48ca11553be49 when we moved reverting signal
> >> mask to happen when the last concurrently running system returns,
> >> despite that signal mask is per thread. This commit reverts this logic
> >> and adds a test.
> >
> > LGTM, thanks.  I *think* you might need to resend it with
> "Signed-off-by:"
> > to mark this as a contribution under DCO.  I don't have access to the
> > FSF records, Florian might help me (sorry to not have it checked
> > earlier).
>
> Sorry, I don't have direct access to FSF records.  I'm told that people
> hang out on OFTC IRC who have, though.
>
> Thanks,
> Florian
>
>