From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mxout5.mail.janestreet.com (mxout5.mail.janestreet.com [64.215.233.18]) by sourceware.org (Postfix) with ESMTPS id E0CC23858D39 for ; Tue, 7 Mar 2023 12:34:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0CC23858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=janestreet.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=janestreet.com Received: from mail-qt1-f197.google.com ([209.85.160.197]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.96) id 1pZWWF-007VX7-1K for libc-alpha@sourceware.org; Tue, 07 Mar 2023 07:34:16 -0500 Received: by mail-qt1-f197.google.com with SMTP id x4-20020ac85384000000b003bfbb485e2dso7022918qtp.22 for ; Tue, 07 Mar 2023 04:34:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1678192456; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=S/cpt2YZGDNBqEIIJZxXwdxi3MTMq4HuNIMVVDmJWUw=; b=W/nKiaIg2eERFTwrvMCcZgUMFnj3RSXIrPW7Ll4lUCVBX76ybkxfDiO17UORxii7vy tXFyGAXtNqqzZY0ScdYvN7B8rpUAU3O+HeuaR5vQp6bKL/eNX52wCaF37dB21b9Pk3pc aGCBFg9Na8pH05x5q9KLZr0BcH46X/TdHWA2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678192456; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S/cpt2YZGDNBqEIIJZxXwdxi3MTMq4HuNIMVVDmJWUw=; b=5UVEGepppzhtqRcbtMRmADAJ1/AfXMJVVgs7hwWUjxK9XicM/zJWvuP+PBrPzlNDQx 4XPr3sNZhbcspxNBvHrw7/VJPoGlzMYo1ld3ieifCrrdaQxrnkic2s/jp2fgDc7jC9Ot x0DVRfhG+YBkgX8axuKEiD7/r69DgButeBUr8FBLeJZaj36iQ12dbA+NXrGioEIJFhWI dhSdRlWeYO9MoWOT1g3mNc7iUwfIiZYSayD6FzS/mqMuPEAA18LxlsrbczzQWFdB1nJV Ua20NUgsivHk8L8smUBJC7l2IskXTW6IuSih5KOV6ij2muvT0hq7lG8TiWBBzy1NAJd5 RO0Q== X-Gm-Message-State: AO0yUKXLmm6mMl2jX7RaHOf8bgUPhAiurfJQe1m5ARsLkn73Jtm1o80q dSapT2QHw3J1XznX/WrKcDuTZyeJ6O/mVo8wTz8/iizJS15CV00izcuA8xy0n2IHtrGQ2/WTWto 4OsjnZ5nO6QEmifZj11pzxV0fWTpI47RPte4= X-Received: by 2002:ad4:5a0e:0:b0:571:e9d3:24a9 with SMTP id ei14-20020ad45a0e000000b00571e9d324a9mr3517400qvb.10.1678192455934; Tue, 07 Mar 2023 04:34:15 -0800 (PST) X-Google-Smtp-Source: AK7set/lC85lQQDgn7/GsdbMPuwjm3OAvqdQc672bbSXFkWbb7ElAQySkY3LytA3xKYPWKTmz/53/3yYpIszwKDgFN0= X-Received: by 2002:ad4:5a0e:0:b0:571:e9d3:24a9 with SMTP id ei14-20020ad45a0e000000b00571e9d324a9mr3517393qvb.10.1678192455645; Tue, 07 Mar 2023 04:34:15 -0800 (PST) MIME-Version: 1.0 References: <6ec79ed7-7798-9566-5a17-4bf47edbf31b@linaro.org> <87ttywoi67.fsf@oldenburg.str.redhat.com> In-Reply-To: <87ttywoi67.fsf@oldenburg.str.redhat.com> From: Adam Yi Date: Tue, 7 Mar 2023 20:33:59 +0800 Message-ID: Subject: Re: [PATCH v5] posix: Fix system blocks SIGCHLD erroneously [BZ #30163] To: Florian Weimer Cc: Adhemerval Zanella Netto , libc-alpha@sourceware.org, schwab@suse.de, i@adamyi.com Content-Type: multipart/alternative; boundary="0000000000002f195205f64ea138" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002f195205f64ea138 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I haven't signed any FSF paperwork. I'll resend the patch with DCO signoff. Thanks! On Tue, Mar 7, 2023 at 8:33=E2=80=AFPM Florian Weimer = wrote: > * Adhemerval Zanella Netto: > > > On 06/03/23 22:52, Adam Yi wrote: > >> Fix bug that SIGCHLD is erroneously blocked forever in the following > >> scenario: > >> > >> 1. Thread A calls system but hasn't returned yet > >> 2. Thread B calls another system but returns > >> > >> SIGCHLD would be blocked forever in thread B after its system() return= s, > >> even after the system() in thread A returns. > >> > >> Although POSIX does not require, glibc system implementation aims to be > >> thread and cancellation safe. This bug was introduced in > >> 5fb7fc96350575c9adb1316833e48ca11553be49 when we moved reverting signal > >> mask to happen when the last concurrently running system returns, > >> despite that signal mask is per thread. This commit reverts this logic > >> and adds a test. > > > > LGTM, thanks. I *think* you might need to resend it with > "Signed-off-by:" > > to mark this as a contribution under DCO. I don't have access to the > > FSF records, Florian might help me (sorry to not have it checked > > earlier). > > Sorry, I don't have direct access to FSF records. I'm told that people > hang out on OFTC IRC who have, though. > > Thanks, > Florian > > --0000000000002f195205f64ea138--