From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by sourceware.org (Postfix) with ESMTPS id A36643858421 for ; Mon, 24 Oct 2022 13:15:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A36643858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=canonical.com Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 830A9412DE for ; Mon, 24 Oct 2022 13:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1666617330; bh=pvDH3xtvq5FiyBf11Ngk+gIfZzFRA6goxYeMSpXiloM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pmpYwSv8DPBa0mGvvUEhl6HW952895oJZH+Kmsz7tY9qN2Z5BLiUkhqZ58QyXOdob v5JNZsVFuU6xdiC6pSZBeau0E5lNIM4+jSQi7ymamViz2qwGitB32HJHSkU64R9RFF UtubESGdMdCccsvvSyDdz6urR+s90BDE3I6y6AlUgqU7meUX+nY9qg886poo6lhe4G vWnYMNVJL1CNkkLpj3f6jcGee2W7kzTsbuZMZLYlC/pf34Gbjfu1FEIc7bFZ3L8Q+d q2KcgUlnOVPbq9/G9szw2rP+u0AikkEbb8o8bpkIlDLnhSZQWwMq3uUCDG8oLyI3gj YOzjdFqxdC9aQ== Received: by mail-lj1-f200.google.com with SMTP id x7-20020a2ea7c7000000b002770aeb6d15so1121541ljp.13 for ; Mon, 24 Oct 2022 06:15:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pvDH3xtvq5FiyBf11Ngk+gIfZzFRA6goxYeMSpXiloM=; b=cNT6b3mvRKtiriLwQ7wt5tOCk+bdiwFFqHcCUu9hiqqo8HDiNNUUo7lQdP1ArlkSmG MNA35M9L1jcwdq3pPt8uhi2Ph/WQNAu4McLhjmpUMVnd8KASOnc+tRKt0nga2ORz7f4n oJFhYFJY/NBPF5gRqUZ6MTNHwG/wfEg1eTqgyOqyFOXlscNpPAWYnaODjHzLcGJ2dWan 3AZm8uELshmzFDnTMZdXpnmzq4R2oLp1hbfsbr4I4QoKjmDZZa9OB4Up1YvEA0Rld+3k mIFvfKL3/5e5kbzZQnGXKgdYi2f66LibJDKuBXJNNXVD77khOv0xrXB1dVjUWjPpbVGD m+MQ== X-Gm-Message-State: ACrzQf3HmsyXSF5z9OPamuy/ZDf01fHIN16yehDqciIRgIkoj7tEbD9Y WP5j4bK8mRYiNhHLVrfIA3sPex28h3EPiC7Fka4FPWuA35qgYro2lILDft6BdiVebqNpsKQj30m 1RZ9O5XvjYqlo/Gja4aMQQPMJ2zjRR6usHQtPjqtn5bH16muYbA7DsQ== X-Received: by 2002:a05:6512:a8e:b0:4a2:675c:9ed8 with SMTP id m14-20020a0565120a8e00b004a2675c9ed8mr11561799lfu.547.1666617329636; Mon, 24 Oct 2022 06:15:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ZHm2t5O+uOWoiku+U+ZUdcb5tonn7Xru+aC9a1LC3xukJBzlIT4e/b3lWL/0I6qCZciV67F1eZ+E3hx4kbEU= X-Received: by 2002:a05:6512:a8e:b0:4a2:675c:9ed8 with SMTP id m14-20020a0565120a8e00b004a2675c9ed8mr11561793lfu.547.1666617329400; Mon, 24 Oct 2022 06:15:29 -0700 (PDT) MIME-Version: 1.0 References: <20220822020504.138206-1-michael.hudson@canonical.com> <8735bd9zpm.fsf@linux.ibm.com> In-Reply-To: <8735bd9zpm.fsf@linux.ibm.com> From: Michael Hudson-Doyle Date: Mon, 24 Oct 2022 15:15:17 +0200 Message-ID: Subject: Re: [PATCH] Fix BZ #29463 in the ibm128 implementation of y1l too To: Tulio Magno Quites Machado Filho Cc: Aurelien Jarno , Michael Hudson-Doyle via Libc-alpha Content-Type: multipart/alternative; boundary="000000000000e5632205ebc7953c" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e5632205ebc7953c Content-Type: text/plain; charset="UTF-8" On Mon, 24 Oct 2022, 14:24 Tulio Magno Quites Machado Filho, < tuliom@ascii.art.br> wrote: > Aurelien Jarno writes: > > > Ping. Tulio (as powerpc machine maintainer) or Joseph (as math component > > maintainer), could you please have a look at this patch? > > I apologize for taking so long to review this. > The code LGTM, but I agree with Aurelien that it needs a better commit > message, > e.g.: > > Avoid moving code across SET_RESTORE_ROUNDL. > > Michael, do you need help in order to merge this? > I have permission to do so but have been completely unable to find the time to do it. If you have a cycle or two to spare it would be great. Cheers, mwh Reviewed-by: Tulio Magno Quites Machado Filho > --000000000000e5632205ebc7953c--