From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id E22DF396E43E for ; Wed, 2 Sep 2020 08:19:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E22DF396E43E Received: by mail-io1-xd44.google.com with SMTP id h4so4882655ioe.5 for ; Wed, 02 Sep 2020 01:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=InUoyvPJ8X/0pkqMw8XbCciaqa1lX2PfpaHb9S93Zvg=; b=qu6ZrMXLpnL29CCYgU27Ay1W9FXOCgDqCWCOtqvUYoW/R/uKDgRfAXGdOUCYEq7DRA cWwoHU8JpY9NnH4Uths/URkOJmIajxvd2CaA7dhC62g/2aIF9hcH7IOa8e5xG2d/HUHR /Iakq3NbvqpL3GMpdtzSP3Q0ybiRs1f3pfPN2xq91zQ4+6vP1Ti8hYjqOCcb75ta7bNZ 8Dr1qhDHItffymdZ+Oo+DFsxUlXfO+ctXCcbghGYnvQh4eaVz+wD+uI4eOr7J0zxtKEQ Yyys7FqKrWeAgztgEOUA2M1o1LJr+CSLWV5TI10K+O6DtBVT2pSEW0zQYIf8hThWKPUf jBhg== X-Gm-Message-State: AOAM531wJP59k54+RRA+GYBaXj/rKaHw5wSN8cndyK1BC9BXf8oMJHhs Fnw0zXlPLA2n36VVuSQ478kwqjgYe85C8Zjppuo= X-Google-Smtp-Source: ABdhPJxolX5Mlf9T8TLBwNIkadVkBM5RUJeYl1CfvopBBBwLY7EVrH58J+WsV4tpHKQX5ER6CqnqMjXLFogGvbI3Wfs= X-Received: by 2002:a02:240d:: with SMTP id f13mr2241006jaa.33.1599034762324; Wed, 02 Sep 2020 01:19:22 -0700 (PDT) MIME-Version: 1.0 References: <20200826022650.1952808-1-ondra.hosek@gmail.com> In-Reply-To: From: =?UTF-8?B?T25kxZllaiBIb8WhZWs=?= Date: Wed, 2 Sep 2020 10:19:11 +0200 Message-ID: Subject: Re: [PATCH] x86-64: Fix FMA4 detection in ifunc [BZ #26534] To: "H.J. Lu" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 08:19:24 -0000 On Wed, Aug 26, 2020 at 5:54 AM H.J. Lu wrote: > > On Tue, Aug 25, 2020 at 7:27 PM Ond=C5=99ej Ho=C5=A1ek via Libc-alpha > wrote: > > > > A typo in commit 107e6a3c2212ba7a3a4ec7cae8d82d73f7c95d0b causes the > > FMA4 code path to be taken on systems that support FMA, even if they do > > not support FMA4. Fix this to detect FMA4. > > [...] > > LGTM. > > Thanks. A week has elapsed since the last comment; may I ask you to commit the patc= h? Thanks! Cheers, ~~ Ondra