From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 7F3073858D35 for ; Sat, 10 Jun 2023 07:19:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3073858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51492ae66a4so3710051a12.1 for ; Sat, 10 Jun 2023 00:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686381597; x=1688973597; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gY40y5Y/1lh1gW3f+7gVbjdqf84f6ETiT+9swzDqxKQ=; b=XLKOfxJt/G+FeDuXyRysAMS/KzXmpwRIlSXv8tvUzMMb7tNKiJMkFX+ajEddO8Vr2y eeH7TAKeYVdNHWgbZ2cIGeohtJWlGkQ3GwHY3puuA5Iv8Sr+w/pDBpe71Ts2AdzRbXHJ CNgZCCnB87CX5HW5rfhyzSMNaGBAiOzoJuzQQNIrA6RP94W0MOJWokq3TBS2DRMKUE33 145Xe3TzTRsBbfoXetWV37357kpW5qltUPkoOZhquoeoh8yrOJR5PZgp8b8ILki/5FN8 slCHRnkC1APYR4mqb+j2hq7HuhdrExu/nvIUuG1NThbWdHMQM57cSNhpgEglhyGlYMEK 9D5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686381597; x=1688973597; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gY40y5Y/1lh1gW3f+7gVbjdqf84f6ETiT+9swzDqxKQ=; b=IWvSY22Y50hc0exlz2OFiL98x3GY/2tRQSUMeBtjGi16JMSzx10hsxK/u/bx/l0Qvl mFuVpRF2jONsbjsrzthiUC27VqTPYAT1wgBBOGRZQpr9N5PvXmShlPOnpMA3yfZIizjJ NykhJ8wPDJTpKCtDTR3JtXlfXr7vXlGDiVx86tPzEUcp2AGyXTdMguKQ4P3t9UYpVlo5 kY8cjjKZXbmS39Q7lt7k36x54afFNAkv5neMGKFFvdPRLLb5N2wR6Wl8P4UHmUnDYug1 12P4codgCboAwXQ/gP3+OFATNYj0vaqYR+mg4FrUvnN7I87cmZ54Fy1pPky/tPFpw6MA sVvQ== X-Gm-Message-State: AC+VfDwjmrVgj5QJtOxr1bz1kxSBAN0Hidc1ec10wZXJziel/lCtCm88 x80vLOTVTLiAHmeNa5M8y0G3M1qiraIpn2WaqWq3Oyrj X-Google-Smtp-Source: ACHHUZ7JHFDZSD1Kd/bqzXIItj4TsavTVnPhvQNSIoXZhvzAzoRWIJMd5Ktgo3UUIYg2op7O6L+4thDageXiQ0wq+30= X-Received: by 2002:aa7:d959:0:b0:514:9e0f:889c with SMTP id l25-20020aa7d959000000b005149e0f889cmr647009eds.16.1686381596970; Sat, 10 Jun 2023 00:19:56 -0700 (PDT) MIME-Version: 1.0 References: <20230525124503.152721-1-dridi.boukelmoune@gmail.com> <38748c18-ce9f-1941-5653-55f9f9d6c529@redhat.com> In-Reply-To: <38748c18-ce9f-1941-5653-55f9f9d6c529@redhat.com> From: Dridi Boukelmoune Date: Sat, 10 Jun 2023 07:19:20 +0000 Message-ID: Subject: Re: [PATCH glibc] posix: Add error message for EAI_OVERFLOW To: "Carlos O'Donell" Cc: Arjun Shankar , libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > The 'gai_strerror()' function is indirectly tested by getaddrinfo() tests in posix/* > > To add a test for this you would: > > - Add a new test in posix/* e.g. posix/tst-gai_strerror.c > - Add the test to posix/Makefile 'tests' target (lines 191-320) in the correct > alpha sort position. > Note: python scripts/sort-makefile-lines.py will sort lines for you. > - Use '#include ' infrastructure. > e.g. posix/tst-fnmatch7.c > > Additional notes here: > https://sourceware.org/glibc/wiki/Testing/Builds With your tips and `make help` I was able to submit a test case. Thanks!