From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by sourceware.org (Postfix) with ESMTPS id F002C3858C35 for ; Tue, 31 Oct 2023 16:20:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F002C3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F002C3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698769210; cv=none; b=foUi+IeZb9L+9P02InROzs1j4R4+eYb9dqUiaMyIANv4+vAdiMoPgeM0Ou5f6ZMgXpSp93EdG1yzRqvv7MajHsK9D5RDktLAXXEMhhZbg6CJmPrra0PgRyT/nkOskt+qMA3ARIeKMw4EC9RfIZN1jUVMrLo/NBItcrScr9yvwjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698769210; c=relaxed/simple; bh=w2ZTOC01wvPMDLhxYweMqNtAHW39rTsOeGMw/qy9x8s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uO2Wpr0qn9Xz2RsClBYFoCEPpc0nnnJP16W4OP/5KVPKwxZ2hoMbXa0IN+Q1GR0L5F8WA2A5pALxyztqP3PIRdflkIoJh4bjRi000A2MQVYwK0OXTDpIjx5JozeX4PcAhQZOW6iK79hu7+Fj6/5i4DYGDdwbk5/XOOZJlfdynIE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-457cb7f53afso2451523137.3 for ; Tue, 31 Oct 2023 09:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698769208; x=1699374008; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aKGP2HhDsX4WmovGU/kCjAFFr1R6bRo2TQ+pDSfQ4X0=; b=lXiAhXu/dJ6r2HDiNREtyLCwXH64AR7Fi8Ces3XU9dzNxU8xfmiAmVILZOqoSILCuI B+RTh5i5gKDp3HjzFIhQhKZYHXoqbHuoUUvCJtC/0J/QiL96mJuLVdzb0RXIpjmsUU5+ PIf432TdgxY5RVuvpCeilU5ilTWO4HK6tr50KtOPzVLYtIzwWhCP3cmgNXzSEWYmNQU8 DT1Qh8kil23WN0XHEz1yUtPf81qPHEAT2n58UOO9g9FIOVsZjA1pUgw8xm1EiVWsZ3VN 7cr5RX/F1OJRuRoWNpjbTG8a8VOc5heWGARr1WddW8sOQPDb6LOz25ggV8LY13abJBpF C4hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698769208; x=1699374008; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKGP2HhDsX4WmovGU/kCjAFFr1R6bRo2TQ+pDSfQ4X0=; b=WJkBN20g/VxLQuhRXSmebJviMFiF7HLl+eSSz9NhSaED6OtvXAOPo3bNGWb3d6InKJ LIqLnvtSHktzm4PBrC43OsMbWT8ln4T+O2DvY2seb52euGevJmDLN9aO48bUmVQZQR8a Kf0ADZvQUAZUcRHExyycKS+nELOOAhPekfbooFAhcxcD5E4+yHcZ2buURp4q5dfjWMLA d3bgNkhEMx6g2W7j0QF/4qow2WEbMl1Fzp0dgSIiil2OKjbRNtcYsLlPNG2NLKJ8FI53 3HtLZS42h5kjQT5vjJqO2G7AQ1cwhGeWaqnEJqGu5R4UdKMwrsCKUNXsCIdRCCNjg9LE OY4w== X-Gm-Message-State: AOJu0YwCiQwdWCV1Q6D+77oxyN2PSHBk1hkwRw8mtJcPQuGnPy5SFVG9 J4IzDFsTga5xg45bJRqBHY2QVvc1xrF8XYwkEWodWw== X-Google-Smtp-Source: AGHT+IG2sqqhoB4K75mb+suwS+zAL1X8ulFktyUTq8OWeR9O7LqanzkHrCjP9tbIjVJh7Z65d+5CRWgkJgc/L3vNiLk= X-Received: by 2002:a67:ac48:0:b0:457:bf8e:c53c with SMTP id n8-20020a67ac48000000b00457bf8ec53cmr12556142vsh.27.1698769208046; Tue, 31 Oct 2023 09:20:08 -0700 (PDT) MIME-Version: 1.0 References: <4678853.9Mp67QZiUf@nimes> In-Reply-To: From: enh Date: Tue, 31 Oct 2023 09:19:56 -0700 Message-ID: Subject: Re: [PATCH] prctl.2: Fix typo To: Alejandro Colomar Cc: Stefan Puiu , Bruno Haible , linux-man@vger.kernel.org, GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 31, 2023 at 9:12=E2=80=AFAM Alejandro Colomar = wrote: > > Hi Stefan, > > On Tue, Oct 31, 2023 at 04:31:58PM +0200, Stefan Puiu wrote: > > Hi Alex and Bruno, > > > > On Tue, Oct 31, 2023 at 4:06=E2=80=AFPM Alejandro Colomar wrote: > > > > > > Hi Bruno, > > > > > > On Sun, Oct 29, 2023 at 09:51:55PM +0100, Bruno Haible wrote: > > > > The synopsis of the prctl.2 page has: > > > > > > > > int prctl(int option, ... > > > > > > > > This makes no sense, because > > > > - the first argument is not optional; it is mandatory. > > > > - the title of the page is "operations on a process or thread". > > > > > > > > It is thus clear that the first argument indicates the operation to= perform. > > > > > > > > Find attached the correction. > > > > > > Agree. I've seen there are other similarly incorrect uses of the wor= d > > > "option" where "operation" should have been used in the same page (bu= t > > > there are some that are correctly used). Would you mind checking the > > > entire page for those other replacements? > > > > Hmm, 'option' is not the same as 'optional'. I guess the first > > Yes, I don't think it means optional, but rather a choice from all the > available operations. However, "operation" would be a more precise > name. > > > parameter can be seen as an 'option' passed to prctl() along with some > > other parameters, right? > > > > Also, there are multiple occurrences of 'option' in the page (e.g. > > 'This option is mainly intended...'), so only changing the argument > > name would introduce an inconsistency in the page. The argument is > > Yes, I think we should also update those when they refer to the first > argument, that is, the operation that prctl(2) will perform. > > > also called '__option' in glibc headers on my system (in > > /usr/include/x86_64-linux-gnu/sys/prctl.h): > > > > /* Control process execution. */ > > #ifndef __USE_TIME_BITS64 > > extern int prctl (int __option, ...) __THROW; > > #else > > # ifdef __REDIRECT > > extern int __REDIRECT_NTH (prctl, (int __option, ...), __prctl_time64); > > I've CCed glibc in case they want to rename it too. > > > > > So, I would say I'm not sure this improves things. > > I think a consistent use of operation instead of option would improve > things. We just need to make sure it's consistent. i certainly like that idea philosophically --- i actually tried to use the minimal number of different words when naming arguments in bionic's headers, to minimize the number of words folks who don't speak english would need to learn. looking at man7, i note that ioctl() and ptrace() have "request". fcntl() has "command". flock() has "operation". > Cheers, > Alex > > > > > Just my 2 cents, > > Stefan. > > -- >