* [PATCH] support: Fix typo in xgetsockname error message
@ 2024-05-17 12:10 Avinal Kumar
2024-05-17 13:49 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Avinal Kumar @ 2024-05-17 12:10 UTC (permalink / raw)
To: libc-alpha; +Cc: Avinal Kumar, Arjun Shankar
The error message in xgetsockname was incorrectly referring to a
different function. This commit fixes that.
Suggested-by: Arjun Shankar <arjun@redhat.com>
Signed-off-by: Avinal Kumar <avinal@redhat.com>
---
It's small but happy to get stated with glibc :)
---
support/xgetsockname.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/xgetsockname.c b/support/xgetsockname.c
index fd1a42ea1e..4f53a874d2 100644
--- a/support/xgetsockname.c
+++ b/support/xgetsockname.c
@@ -26,5 +26,5 @@ void
xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen)
{
if (getsockname (fd, sa, plen) != 0)
- FAIL_EXIT1 ("setsockopt (%d): %m", fd);
+ FAIL_EXIT1 ("getsockname (%d): %m", fd);
}
--
2.45.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] support: Fix typo in xgetsockname error message
2024-05-17 12:10 [PATCH] support: Fix typo in xgetsockname error message Avinal Kumar
@ 2024-05-17 13:49 ` Carlos O'Donell
2024-05-17 14:34 ` Avinal Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2024-05-17 13:49 UTC (permalink / raw)
To: Avinal Kumar, libc-alpha; +Cc: Arjun Shankar
On 5/17/24 8:10 AM, Avinal Kumar wrote:
> The error message in xgetsockname was incorrectly referring to a
> different function. This commit fixes that.
>
> Suggested-by: Arjun Shankar <arjun@redhat.com>
> Signed-off-by: Avinal Kumar <avinal@redhat.com>
As a Red Hat employee you are covered under the corporate assignment unless your
work contract explicitly has you owning your contributions (in which case you would
need a personal assignment or contribution under DCO).
Please clarify:
(a) Are you contributing under Red Hat's corporate assignment to the FSF?
(b) Are you contributing under DCO? In which case the file's copyright statement
needs updating.
Looking forward to a v2.
> ---
> It's small but happy to get stated with glibc :)
> ---
> support/xgetsockname.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/xgetsockname.c b/support/xgetsockname.c
> index fd1a42ea1e..4f53a874d2 100644
> --- a/support/xgetsockname.c
> +++ b/support/xgetsockname.c
> @@ -26,5 +26,5 @@ void
> xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen)
> {
> if (getsockname (fd, sa, plen) != 0)
> - FAIL_EXIT1 ("setsockopt (%d): %m", fd);
> + FAIL_EXIT1 ("getsockname (%d): %m", fd);
> }
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] support: Fix typo in xgetsockname error message
2024-05-17 13:49 ` Carlos O'Donell
@ 2024-05-17 14:34 ` Avinal Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Avinal Kumar @ 2024-05-17 14:34 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, Arjun Shankar
[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]
Thank you Carlos for the clarification. I was not aware of such rules.
a) No, I am not contributing under Red Hat's corporate assignment.
b) This should be the case since I am personally interested in contributing.
I will send a revised patch soon with corrections.
On Fri, May 17, 2024 at 1:49 PM Carlos O'Donell <carlos@redhat.com> wrote:
> On 5/17/24 8:10 AM, Avinal Kumar wrote:
> > The error message in xgetsockname was incorrectly referring to a
> > different function. This commit fixes that.
> >
> > Suggested-by: Arjun Shankar <arjun@redhat.com>
> > Signed-off-by: Avinal Kumar <avinal@redhat.com>
>
> As a Red Hat employee you are covered under the corporate assignment
> unless your
> work contract explicitly has you owning your contributions (in which case
> you would
> need a personal assignment or contribution under DCO).
>
> Please clarify:
>
> (a) Are you contributing under Red Hat's corporate assignment to the FSF?
>
> (b) Are you contributing under DCO? In which case the file's copyright
> statement
> needs updating.
>
> Looking forward to a v2.
>
> > ---
> > It's small but happy to get stated with glibc :)
> > ---
> > support/xgetsockname.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/support/xgetsockname.c b/support/xgetsockname.c
> > index fd1a42ea1e..4f53a874d2 100644
> > --- a/support/xgetsockname.c
> > +++ b/support/xgetsockname.c
> > @@ -26,5 +26,5 @@ void
> > xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen)
> > {
> > if (getsockname (fd, sa, plen) != 0)
> > - FAIL_EXIT1 ("setsockopt (%d): %m", fd);
> > + FAIL_EXIT1 ("getsockname (%d): %m", fd);
> > }
>
> --
> Cheers,
> Carlos.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-17 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-17 12:10 [PATCH] support: Fix typo in xgetsockname error message Avinal Kumar
2024-05-17 13:49 ` Carlos O'Donell
2024-05-17 14:34 ` Avinal Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).