From: Arnd Bergmann <arnd@arndb.de>
To: Vincent Chen <vincentc@andestech.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>,
Vincent Chen <deanbo422@gmail.com>,
cnoize@andestech.com
Subject: Re: [PATCH v3 08/13] nds32: Linux ABI
Date: Thu, 13 Sep 2018 12:06:00 -0000 [thread overview]
Message-ID: <CAK8P3a2nRmXnh+Bbx06DKwA-EX7CnQ-g0=KicpnmHqWF1KSFFQ@mail.gmail.com> (raw)
In-Reply-To: <1528960976-10934-9-git-send-email-vincentc@andestech.com>
On Thu, Jun 14, 2018 at 9:26 AM Vincent Chen <vincentc@andestech.com> wrote:
> diff --git a/sysdeps/unix/sysv/linux/nds32/sys/procfs.h b/sysdeps/unix/sysv/linux/nds32/sys/procfs.h
> new file mode 100644
> index 0000000..06dce6b
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/nds32/sys/procfs.h
....
> +#define ELF_PRARGSZ (80) /* Number of chars for args. */
> +
> +struct elf_prpsinfo
> + {
> + char pr_state; /* Numeric process state. */
> + char pr_sname; /* Char for pr_state. */
> + char pr_zomb; /* Zombie. */
> + char pr_nice; /* Nice val. */
> + unsigned long int pr_flag; /* Flags. */
> + unsigned short int pr_uid;
> + unsigned short int pr_gid;
> + int pr_pid, pr_ppid, pr_pgrp, pr_sid;
> + char pr_fname[16]; /* Filename of executable. */
> + char pr_psargs[ELF_PRARGSZ]; /* Initial part of arg list. */
> + };
I just checked this one and found the same bug that was mentioned in the
csky review thread for a few architectures (not csky):
pr_uid/pr_gid are 'unsigned int' in the kernel, not 'unsigned short int'.
Arnd
next prev parent reply other threads:[~2018-09-13 12:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 7:23 [PATCH v3 00/13] nds32 glibc port, v3 Vincent Chen
2018-06-14 7:23 ` [PATCH v3 01/13] nds32: Build Infastructure Vincent Chen
2018-06-14 13:27 ` Joseph Myers
2018-06-15 7:42 ` Vincent Chen
2018-06-14 7:23 ` [PATCH v3 02/13] nds32: ABI Implementation Vincent Chen
2018-06-14 7:23 ` [PATCH v3 03/13] nds32: Thread-Local Storage Support Vincent Chen
2018-06-14 7:24 ` [PATCH v3 07/13] nds32: Linux Syscall Interface Vincent Chen
2018-06-14 13:34 ` Joseph Myers
2018-06-15 7:47 ` Vincent Chen
2018-06-14 7:24 ` [PATCH v3 08/13] nds32: Linux ABI Vincent Chen
2018-09-13 12:06 ` Arnd Bergmann [this message]
2018-09-17 0:50 ` Vincent Chen
2018-06-14 7:24 ` [PATCH v3 04/13] nds32: Startup and Dynamic Loader Vincent Chen
2018-06-14 7:24 ` [PATCH v3 05/13] nds32: Generic <math.h> and soft-fp Routines Vincent Chen
2018-06-14 7:24 ` [PATCH v3 06/13] nds32: Atomic and Locking Routines Vincent Chen
2018-06-14 7:25 ` [PATCH v3 13/13] Add nds32 port to build-many-glibcs.py Vincent Chen
2018-06-14 7:25 ` [PATCH v3 10/13] Skeleton documentation for the nds32 port Vincent Chen
2018-06-14 7:49 ` [PATCH v3 09/13] nds32: Add ABI list Vincent Chen
2018-06-14 8:34 ` Andreas Schwab
2018-06-14 7:50 ` [PATCH v3 11/13] Add Andes nds32 dynamic relocation type to elf/elf.h Vincent Chen
2018-06-14 7:50 ` [PATCH v3 12/13] Add nds32 entries to config.h.in Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2nRmXnh+Bbx06DKwA-EX7CnQ-g0=KicpnmHqWF1KSFFQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=cnoize@andestech.com \
--cc=deanbo422@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=vincentc@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).