From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49816 invoked by alias); 7 May 2018 02:49:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49551 invoked by uid 89); 7 May 2018 02:48:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=reviews, shortly X-HELO: mailbackend.panix.com X-Gm-Message-State: ALQs6tA5q6tWsDaxTGyGfyzO71iw3+CbJ59LD2Ct2DutKx2C9VeJrpSs gb26HkgqgTDrTSJs5EX6ho63y4QPEcC2B5RokCA= X-Google-Smtp-Source: AB8JxZrsX9uTl4r4Xl+opTGvi8933yJzAwHzbHFVABg5cr3X/wNwv77nAfC7Kh+r2MG8WEvCgH+hfeFxD69IWiNu6Rs= X-Received: by 2002:aca:6986:: with SMTP id e128-v6mr21473052oic.181.1525661285294; Sun, 06 May 2018 19:48:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4141f1f5-c4b2-f94c-6fe2-b961f5e3ee8a@linaro.org> References: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> <1519679016-12241-4-git-send-email-adhemerval.zanella@linaro.org> <4141f1f5-c4b2-f94c-6fe2-b961f5e3ee8a@linaro.org> From: Zack Weinberg Date: Mon, 07 May 2018 02:49:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/21] nptl: Fix Race conditions in pthread cancellation (BZ#12683) To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-05/txt/msg00156.txt.bz2 On Fri, Apr 27, 2018 at 8:25 AM, Adhemerval Zanella wrote: > On 27/04/2018 09:20, Zack Weinberg wrote: >> On Mon, Feb 26, 2018 at 4:03 PM, Adhemerval Zanella >> wrote: >>> This patches fixes some race conditions in NPTL cancellation code by >>> redefining how cancellable syscalls are defined and handled. Current >>> approach is to enable asynchronous cancellation prior to making the syscall >>> and restore the previous cancellation type once the syscall returns. >> >> Did these patches ever get reviewed/committed? #12683 has been >> festering for a long time... > > Thanks for bring this up. No, I haven't received any review so far about it. Let's try to unjam this. I will post reviews for patches 1, 2, 3, 4, and 6 shortly. Unfortunately, all of the other patches require review by architecture experts; I don't know enough about the low-level ABI details for anything other than plain x86-32 and -64. zw