From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19134 invoked by alias); 13 Mar 2018 13:37:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 19122 invoked by uid 89); 13 Mar 2018 13:37:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mailbackend.panix.com X-Gm-Message-State: AElRT7E7fF3n5t9yje1WPbTF5JSwuWFUQKTUl7VmKMWWe0+ECP2+0hoy 8O+bxaRCN5yktJi9KIYvzKNEryp53INW1JPpzfw= X-Google-Smtp-Source: AG47ELtybTqgWDKApXDErJE7/X/tAqn8ul2AVZ6n5dLjaGyfIY8qujkSQhXb8+x5V/Piodgda7Wp759uVDXIh5Fnxmo= X-Received: by 10.157.91.78 with SMTP id e14mr515042otj.134.1520948234921; Tue, 13 Mar 2018 06:37:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180307193205.4751-1-zackw@panix.com> <20180307193205.4751-7-zackw@panix.com> <697f02d0-e414-ac84-04c8-79530276f2dc@redhat.com> From: Zack Weinberg Date: Tue, 13 Mar 2018 13:37:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal. To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-03/txt/msg00315.txt.bz2 On Tue, Mar 13, 2018 at 8:43 AM, Florian Weimer wrote: > On 03/13/2018 01:39 PM, Zack Weinberg wrote: >> >> On Tue, Mar 13, 2018 at 7:59 AM, Florian Weimer >> wrote: >>> >>> On 03/07/2018 08:32 PM, Zack Weinberg wrote: >>> >>>> +/* __vsyslog_internal uses the same mode_flags bits as >>>> + __v*printf_internal; see libio/libioP.h. */ >>>> +extern void __vsyslog_internal (int pri, const char *fmt, >>>> __gnuc_va_list >>>> ap, >>>> + unsigned int mode_flags) >>>> + __attribute__ ((__format__ (__printf__, 2, 0))); >>> >>> >>> >>> I'm surprised that this doesn't need attribute_hidden or >>> libc_hidden_proto >>> to avoid new PLT calls. >> >> >> That's only needed for functions that will be called _both_ from >> inside and outside glibc. This function is only ever called from >> inside glibc, so it doesn't appear in any Versions files and it's >> hidden by default. > > > Some architectures will still use indirect calls without attribute_hidden, > so please add it. The existing tests do not catch this reliably > unfortunately. Can you be more specific? This will affect all of the other new __*_internal functions added in this patchset, so I need to know how to be sure I got it right. Also, this seems like something we should find a way to automate if at all possible. zw