From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128897 invoked by alias); 4 Apr 2018 17:49:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128871 invoked by uid 89); 4 Apr 2018 17:48:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mailbackend.panix.com X-Gm-Message-State: ALQs6tD1vSTrINUKOfNTviabe123IyZN02hSLMXFTJzzRp4buMw4/sJs T8QiVf1aaenUnatyeOXmfV9TrEMJZgHN8QSbW2M= X-Google-Smtp-Source: AIpwx49eE8NjI90TVEhH5YDaDmqU3IfhTQpggtoFnGAwVK6H218xHZU9O0DK5WL7M2Am/30bwSgi33AoCGvTMP7duvA= X-Received: by 2002:a9d:73c1:: with SMTP id m1-v6mr12146149otk.166.1522864135576; Wed, 04 Apr 2018 10:48:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <8f56a2a9-7c17-857c-0e7b-d003156536c2@linaro.org> References: <20180404164518.11147-1-zackw@panix.com> <8f56a2a9-7c17-857c-0e7b-d003156536c2@linaro.org> From: Zack Weinberg Date: Wed, 04 Apr 2018 17:49:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [COMMITTED PATCH] Make sysdeps/generic/internal-signals.h less stubby. To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-04/txt/msg00122.txt.bz2 On Wed, Apr 4, 2018 at 1:42 PM, Adhemerval Zanella wrote: > On 04/04/2018 13:45, Zack Weinberg wrote: >> Three of the functions defined by internal-signals.h were not actually >> fulfilling their contracts when the sysdeps/generic version of that >> file was used. Also, the Linux version included several more headers >> than the generic version, which is the root cause of a build failure >> on Hurd (already addressed in another way, but I think it is proper to >> make the headers match). >> >> In principle, __libc_signal_block_all, __libc_signal_block_app, and >> __libc_signal_restore_set could be defined in non-system-dependent >> code, leaving only __is_internal_signal and __clear_internal_signal to >> be defined by a sysdeps header, but the Linux version of >> internal-signals.h wants to inline a raw rt_sigprocmask syscall, and I >> don't feel like messing with that today. > > Thanks for catching it. If I remember correctly, I used an inlined > rt_sigprocmask for Linux because both sigprocmask and pthread_sigmask > filter both SIGCANCEL and SIGSETXID. We could use it for > __libc_signal_block_app, but __libc_signal_block_all and > __libc_signal_restore_set would require a new symbol. Yeah, that's what I thought was going on. I think it's fine the way it is at least for now. zw