From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33606 invoked by alias); 16 Jul 2018 12:36:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 33596 invoked by uid 89); 16 Jul 2018 12:36:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:636 X-HELO: mailbackend.panix.com MIME-Version: 1.0 In-Reply-To: <23901f64-d483-f587-6a1e-2af2f5bdecdb@linux.ibm.com> References: <23901f64-d483-f587-6a1e-2af2f5bdecdb@linux.ibm.com> From: Zack Weinberg Date: Mon, 16 Jul 2018 12:36:00 -0000 Message-ID: Subject: Re: Fix string/tst-xbzero-opt if build with gcc head. To: Stefan Liebler Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-07/txt/msg00425.txt.bz2 On Mon, Jul 16, 2018 at 7:05 AM, Stefan Liebler wrote: > On 07/12/2018 06:42 PM, Zack Weinberg wrote: >> I would prefer us to find some kind of construct that >> actually does make externally-visible side effects depend on the >> contents of 'buf' in terms of the C abstract machine. >> > > Okay. Then here is a new version of the patch without the empty asm. > If build with GCC head on s390x, setup_no_clear is now filling the buffer > and setup_ordinary_clear is just a tail call to setup_no_clear (same > behaviour as before). Yes, this change is OK. zw