From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zackw@panix.com>
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89])
 by sourceware.org (Postfix) with ESMTPS id 8EA06384400A
 for <libc-alpha@sourceware.org>; Tue, 16 Feb 2021 16:38:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8EA06384400A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=panix.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zackw@panix.com
Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com
 [209.85.208.42])
 by mailbackend.panix.com (Postfix) with ESMTPSA id 4Dg69b6QxTz1GFq
 for <libc-alpha@sourceware.org>; Tue, 16 Feb 2021 11:38:43 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix;
 t=1613493523; bh=0CSFWmXQrI+XkmVi9mMf3YQUipAitZwQB1gNh07yrEc=;
 h=References:In-Reply-To:From:Date:Subject:To:Cc;
 b=tTBa86CtVWum8xfgcnw2Jxmufwn/29+Rjt4MxqtnwCc1qJ2NLf27iv61v0cyKwwRF
 NNjpsCglZrTehlev0TcNVDCZcuSLDTMu6pixey7nWcr3fege1RrVWRElC1rs7fad/T
 YXkgG8SOAwj6MQvxfEXO98XRxnL3iwX33O/yZQX8=
Received: by mail-ed1-f42.google.com with SMTP id j9so2761404edp.1
 for <libc-alpha@sourceware.org>; Tue, 16 Feb 2021 08:38:43 -0800 (PST)
X-Gm-Message-State: AOAM531sFIyWyk43JZK5jYhLag9c9b8vLxnZc7Jt6NBmU6vHh4ERCUhV
 wGmo0j6i+sr65wlfWZ4FO/qYKT0J9S4FryOlMeA=
X-Google-Smtp-Source: ABdhPJzeznVHAo9dR9JooGLNOs2shnARc6HhQ4SD3GaKYfaUXSxOaYpCX73sJKSeZqYsFExkzdQyF6H8h3QNFoTZfDs=
X-Received: by 2002:a05:6402:190a:: with SMTP id
 e10mr21924107edz.110.1613493522952; 
 Tue, 16 Feb 2021 08:38:42 -0800 (PST)
MIME-Version: 1.0
References: <20210216115912.213547-1-naohirot@fujitsu.com>
In-Reply-To: <20210216115912.213547-1-naohirot@fujitsu.com>
From: Zack Weinberg <zackw@panix.com>
Date: Tue, 16 Feb 2021 11:38:31 -0500
X-Gmail-Original-Message-ID: <CAKCAbMhKfHN_T9h2qLeBiFxvG_F9186LLAk0NJvEPa_1RVm1Dg@mail.gmail.com>
Message-ID: <CAKCAbMhKfHN_T9h2qLeBiFxvG_F9186LLAk0NJvEPa_1RVm1Dg@mail.gmail.com>
Subject: Re: [PATCH 1/3] Replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE
To: Naohiro Tamura <naohirot@fujitsu.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2021 16:38:45 -0000

On Tue, Feb 16, 2021 at 7:00 AM Naohiro Tamura <naohirot@fujitsu.com> wrote:
> This patch replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE.
> It has been confirmed that GNU 'autoconf' 2.69 doesn't change any
> 'configure' files and suppressed obsolete warnings.

Thanks for doing this work.

> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
>  #ifndef __CET__
>  # error no CET compiler support
> -#endif],
> +#endif]])],

This, and any other check where the code is entirely preprocessor
directives, should be changed to AC_PREPROC_IFELSE for efficiency.

> -AC_TRY_COMPILE([#include <float.h>], [
> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <float.h>[]], [[

Typo here: it should be

> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <float.h>]], [[

I believe this is the root cause of the problem Andreas pointed out.

I did not proofread the entire patch.

zw