From: Zack Weinberg <zackw@panix.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>,
Siddhesh Poyarekar <siddhesh@gotplt.org>
Subject: Re: [PATCH v2] [BZ 1190] Make EOF sticky in stdio.
Date: Tue, 13 Mar 2018 12:37:00 -0000 [thread overview]
Message-ID: <CAKCAbMi12jc8_LJrk=7uQDWRNXL7KdVgbNxr2A=2xUufBaKq1w@mail.gmail.com> (raw)
In-Reply-To: <mvmo9jsmhb5.fsf@suse.de>
On Tue, Mar 13, 2018 at 5:54 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Mär 13 2018, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 03/12/2018 11:46 PM, Andreas Schwab wrote:
>>>> - tst-ftell-append tst-fputws tst-bz22415
>>>> + tst-ftell-append tst-fputws tst-bz22415 tst-fgetc-after-eof \
>>
>>> Spurious backslash.
>>
>> Some of us use this style to avoid spurious -/+ line changes, just to add
>> the backslash in a subsequent patch.
>
> That can easily go wrong.
Without expressing an opinion either way on whether this is good
style, it does not seem to be the practice in libio/Makefile in
general, so I have removed the offending backslash in the version of
the patch I just pushed to master.
zw
prev parent reply other threads:[~2018-03-13 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 1:04 Zack Weinberg
2018-03-12 15:31 ` Zack Weinberg
2018-03-12 22:46 ` Andreas Schwab
2018-03-13 9:52 ` Florian Weimer
2018-03-13 9:54 ` Andreas Schwab
2018-03-13 12:37 ` Zack Weinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCAbMi12jc8_LJrk=7uQDWRNXL7KdVgbNxr2A=2xUufBaKq1w@mail.gmail.com' \
--to=zackw@panix.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).