From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104838 invoked by alias); 18 Nov 2016 16:28:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 104819 invoked by uid 89); 18 Nov 2016 16:28:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=logfiles, ergonomic, Hx-languages-length:1910 X-HELO: mailbackend.panix.com X-Gm-Message-State: AKaTC02rogLNbdzA8xDA9jP8LaVfSimD58j5QxnIBJWavgoZkkKJgkAJP+Vxyj0aP/I723SZT9/7TOIfPT5gMA== X-Received: by 10.28.189.69 with SMTP id n66mr615100wmf.35.1479486471521; Fri, 18 Nov 2016 08:27:51 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Zack Weinberg Date: Fri, 18 Nov 2016 16:28:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Add script to build many glibc configurations To: Joseph Myers Cc: GNU C Library Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-11/txt/msg00664.txt.bz2 On Thu, Nov 17, 2016 at 12:51 PM, Joseph Myers wrote: > On Thu, 17 Nov 2016, Zack Weinberg wrote: >> On 11/09/2016 11:27 AM, Joseph Myers wrote: >> > This patch adds a Python (3.5 or later) script to build many different >> > configurations of glibc ... >> >> Since this does its own glibc checkout, it's not clear to me how one >> should use it to test a patch(set)... > > You patch the script's glibc checkout (or switch it to a different branch, > or whatever) at some point after the checkout step and before running the > "glibcs" build... Thanks, I have it working now. I'd like to mention some more places where the script could be more ergonomic for patch testing: * Please don't delete the build tree unless configure, build, and check all succeed, so that one can dig into a failure beyond what's visible in the logs. Add an option to preserve the build tree even if all three succeeded, to facilitate additional testing (for instance, an "installed stripped libraries are unchanged" test - if that fails one will want to go look at the object files). * Please find some way of not needing to make a copy of the glibc source tree for each build configuration, so that one can make edits to .../src/glibc and immediately do incremental rebuilds in all failing configurations. * Please make sure that command lines written to logfiles are properly quoted, so that they can be copied and pasted directly into a shell. (The problem case I know about is CC="x-y-z-gcc -mthis -mthat" on a configure command line, which currently gets written to the logfile without any quotes.) (Python stdlib has a function `shlex.quote` that will help.) I'm kibitzing a lot, so let me say that this script is really, really useful and I can see lots of cases where it will make complex changes easier to validate. Thanks for writing it. zw