From: Zack Weinberg <zackw@panix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [hurd,commited] hurd: do not check Mach and Hurd headers
Date: Mon, 05 Mar 2018 00:30:00 -0000 [thread overview]
Message-ID: <CAKCAbMiBAPTbAWicLCG6UokSDvpgpXgHaPTfyiUD79kUE9UNYQ@mail.gmail.com> (raw)
In-Reply-To: <20180304180959.owoben7mpnpjuryp@var.youpi.perso.aquilenet.fr>
On Sun, Mar 4, 2018 at 1:09 PM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> Zack Weinberg, on dim. 04 mars 2018 11:08:00 -0500, wrote:
>> On Sat, Mar 3, 2018 at 9:55 PM, Samuel Thibault
>> <samuel.thibault@ens-lyon.org> wrote:
>> > Joseph Myers, on sam. 03 mars 2018 22:53:23 +0000, wrote:
>> >> it should always be possible to write a header in a way that
>> >> doesn't have such a requirement.
>> >
>> > I'm almost there, the only remaining issue is that hurd/hurd/signal.h
>> > uses struct sigaction. I guess I should move existing definitions to a
>> > struct_sigaction.h header?
>>
>> In this case, you just need a Hurd version of the existing
>> bits/sigaction.h.
>
> I don't understand why a different version. Can't I just make
> hurd/hurd/signal.h include <bits/sigaction.h>? (well, there is a
> technical reason: it does not have multi-inclusion guard, but that can
> be fixed)
Oh, yes, if the existing generic bits/sigaction.h works for Hurd then
that's fine. I thought there had to be something wrong with it,
because hurd/signal.h already includes signal.h which includes
bits/sigaction.h ... but now I realize that the problem is signal.h
doesn't _always_ include bits/sigaction.h.
zw
prev parent reply other threads:[~2018-03-05 0:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 19:18 Samuel Thibault
2018-03-03 22:08 ` Joseph Myers
2018-03-03 22:32 ` Samuel Thibault
2018-03-03 22:53 ` Joseph Myers
2018-03-03 23:57 ` Samuel Thibault
2018-03-04 1:33 ` Joseph Myers
2018-03-04 1:35 ` Samuel Thibault
2018-03-04 1:41 ` Joseph Myers
2018-03-04 1:43 ` Samuel Thibault
2018-03-04 1:46 ` Joseph Myers
2018-03-04 1:46 ` Samuel Thibault
2018-03-04 0:32 ` Samuel Thibault
2018-03-04 1:28 ` Joseph Myers
2018-03-04 2:55 ` Samuel Thibault
2018-03-04 16:08 ` Zack Weinberg
2018-03-04 18:10 ` Samuel Thibault
2018-03-05 0:30 ` Zack Weinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKCAbMiBAPTbAWicLCG6UokSDvpgpXgHaPTfyiUD79kUE9UNYQ@mail.gmail.com \
--to=zackw@panix.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).