From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119991 invoked by alias); 9 Dec 2019 16:50:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 119982 invoked by uid 89); 9 Dec 2019 16:50:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:be0147f, H*i:sk:be0147f, murphy, murphyp@linux.ibm.com X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <20191203170540.18428-1-gabriel@inconstante.net.br> <20191203170540.18428-2-gabriel@inconstante.net.br> In-Reply-To: From: Zack Weinberg Date: Mon, 09 Dec 2019 16:50:00 -0000 Message-ID: Subject: Re: [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf To: Paul E Murphy Cc: "Gabriel F. T. Gomes" , GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-12/txt/msg00290.txt.bz2 On Mon, Dec 9, 2019 at 11:46 AM Paul E Murphy wrote: > On 12/3/19 11:05 AM, Gabriel F. T. Gomes wrote: > > From: "Gabriel F. T. Gomes" > > > > New since v2. > > > > -- 8< -- > > Since commit > > > > commit 03992356e6fedc5a5e9d32df96c1a2c79ea28a8f > > Author: Zack Weinberg > > Date: Sat Feb 10 11:58:35 2018 -0500 > > > > Use C99-compliant scanf under _GNU_SOURCE with modern compilers. > > > > the selection of the GNU versions of scanf functions requires both > > _GNU_SOURCE and -std=c89. This patch changes the tests in > > ldbl-128ibm-compat so that they actually test the GNU versions (without > > this change, the redirection to the ISO C99 version always happens, so > > GNU versions of the new implementation (e.g. __scanfieee128) were left > > untested). > > Good catch Zach, thanks. Credit is actually due to Gabriel; if I understand correctly, I _introduced_ a bug here! zw