From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91004-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 44714 invoked by alias); 13 Mar 2018 12:39:26 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 44705 invoked by uid 89); 13 Mar 2018 12:39:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: mailbackend.panix.com
X-Gm-Message-State: AElRT7EP5TE3afqzmSXX53/GyFLiQY8zaUOmbIkFgoCKbdro3qQCBHgr
	9131WAFf0cDwJk8SLjZkq/EMlJDqpuJQaHDFRTg=
X-Google-Smtp-Source: AG47ELvBemKVV5CGoQxnSiEkKSfS7NSxymvz+VRwRVyS8j6mKcrTSXYpJTAjXwW6y68E515a+pjutcpmfpCzme/iyFQ=
X-Received: by 10.157.23.236 with SMTP id j99mr341164otj.77.1520944762451;
 Tue, 13 Mar 2018 05:39:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <697f02d0-e414-ac84-04c8-79530276f2dc@redhat.com>
References: <20180307193205.4751-1-zackw@panix.com> <20180307193205.4751-7-zackw@panix.com>
 <697f02d0-e414-ac84-04c8-79530276f2dc@redhat.com>
From: Zack Weinberg <zackw@panix.com>
Date: Tue, 13 Mar 2018 12:39:00 -0000
X-Gmail-Original-Message-ID: <CAKCAbMiRSZxBfF9_At0afOab95hVnqo22AsTFr24WgaxDzrU4g@mail.gmail.com>
Message-ID: <CAKCAbMiRSZxBfF9_At0afOab95hVnqo22AsTFr24WgaxDzrU4g@mail.gmail.com>
Subject: Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-03/txt/msg00311.txt.bz2

On Tue, Mar 13, 2018 at 7:59 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 03/07/2018 08:32 PM, Zack Weinberg wrote:
>
>> +/* __vsyslog_internal uses the same mode_flags bits as
>> +   __v*printf_internal; see libio/libioP.h.  */
>> +extern void __vsyslog_internal (int pri, const char *fmt, __gnuc_va_list
>> ap,
>> +                                unsigned int mode_flags)
>> +     __attribute__ ((__format__ (__printf__, 2, 0)));
>
>
> I'm surprised that this doesn't need attribute_hidden or libc_hidden_proto
> to avoid new PLT calls.

That's only needed for functions that will be called _both_ from
inside and outside glibc.  This function is only ever called from
inside glibc, so it doesn't appear in any Versions files and it's
hidden by default.

zw