public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zack Weinberg <zackw@panix.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH COMMITTED] resolv: Compile without -Wno-write-strings
Date: Tue, 11 Oct 2016 16:52:00 -0000	[thread overview]
Message-ID: <CAKCAbMicwNMfjtSPgmCtGOAm2erL0eu04SaMDnihjLR_yuPO-Q@mail.gmail.com> (raw)
In-Reply-To: <20161011135022.1A7EE439942EF@oldenburg.str.redhat.com>

On Tue, Oct 11, 2016 at 9:50 AM, Florian Weimer <fweimer@redhat.com> wrote:
>  extern const struct res_sym __p_class_syms[];
>  libresolv_hidden_proto (__p_class_syms)
>  const struct res_sym __p_class_syms[] = {
> -       {C_IN,          "IN"},
> -       {C_CHAOS,       "CHAOS"},
> -       {C_HS,          "HS"},
> -       {C_HS,          "HESIOD"},
> -       {C_ANY,         "ANY"},
> -       {C_NONE,        "NONE"},
> -       {C_IN,          (char *)0}
> +  {C_IN,    (char *) "IN"},
> +  {C_CHAOS, (char *) "CHAOS"},
> +  {C_HS,    (char *) "HS"},
> +  {C_HS,    (char *) "HESIOD"},
> +  {C_ANY,   (char *) "ANY"},
> +  {C_NONE,  (char *) "NONE"},
> +  {C_IN, NULL, NULL}

As these (appear to be) internal symbols, why can't we make `struct
res_sym` const-correct instead of adding all these casts?

zw

  reply	other threads:[~2016-10-11 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 13:50 Florian Weimer
2016-10-11 16:52 ` Zack Weinberg [this message]
2016-10-11 16:56   ` Florian Weimer
2016-10-11 19:03     ` Zack Weinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCAbMicwNMfjtSPgmCtGOAm2erL0eu04SaMDnihjLR_yuPO-Q@mail.gmail.com \
    --to=zackw@panix.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).