public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zack Weinberg <zackw@panix.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "GNU C Library" <libc-alpha@sourceware.org>,
	"Björn Esser" <bjoern.esser@gmail.com>,
	"Florian Weimer" <fweimer@redhat.com>
Subject: Re: [PATCH] Deprecate libcrypt and don't build it by default.
Date: Tue, 29 Aug 2017 20:49:00 -0000	[thread overview]
Message-ID: <CAKCAbMimWSk5otjDaZNgPz8cnYDj0VTveg32V0Mp5rSTMJYMhQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1708292004560.23565@digraph.polyomino.org.uk>

On Tue, Aug 29, 2017 at 4:16 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Tue, 29 Aug 2017, Zack Weinberg wrote:
>> Back in June, Björn Esser proposed to add OpenBSD-compatible bcrypt
>> support to our implementation of crypt(3), and I replied that it might
>> actually make more sense to _remove_ libcrypt from glibc, freeing up
>> libcrypt.so.1 and crypt.h to be provided by a separate project that
>> could move faster.  (For instance, libxcrypt:
>> https://github.com/besser82/libxcrypt)
>
> I don't believe libxcrypt's claim to be a binary-compatible replacement
> for libcrypt.so.1.  It looks to me like it uses symbol version GLIBC_2.0
> unconditionally for the glibc symbols, when the actual base version
> depends on the architecture / ABI for which glibc is built; GLIBC_2.0 is
> only for a few architectures such as i386 with very longstanding ports.

Well, that's just a plain old bug.  Obviously a bug that needs to be
fixed before we can call libxcrypt a binary-compatible drop-in
replacement, but not a _difficult_ bug - they can crib from the
libcrypt.abilist files.  I'm willing to try to work up a patch if
Björn agrees.

(The soname needs to be libcrypt.so.1.1 on alpha, too.)

zw

  reply	other threads:[~2017-08-29 20:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 18:43 Zack Weinberg
2017-08-29 20:16 ` Joseph Myers
2017-08-29 20:49   ` Zack Weinberg [this message]
2017-08-29 20:58     ` Joseph Myers
2017-08-29 21:20       ` Zack Weinberg
2017-08-31 17:30         ` Carlos O'Donell
2017-09-08 13:23           ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCAbMimWSk5otjDaZNgPz8cnYDj0VTveg32V0Mp5rSTMJYMhQ@mail.gmail.com \
    --to=zackw@panix.com \
    --cc=bjoern.esser@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).