Re: [PATCH] New configure option --disable-libcrypt.

[Zack Weinberg <zackw@panix.com>]

On Tue, Apr 17, 2018 at 6:21 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 04/16/2018 05:56 PM, Zack Weinberg wrote:
>
>> Let me see if I understand what you have in mind:  In
>> --disable-libcrypt mode, we would preserve _XOPEN_CRYPT, with value 1,
>> and the prototype for crypt in unistd.h.
>
> My main proposal is preserving the prototype for crypt, under _GNU_SOURCE if
> necessary (without defining _XOPEN_CRYPT).
>
> I just don't see value in the friction caused by dropping the definition.

Makes sense.

> It could still be a conformance violation for setkey/encrypt because current
> libxcrypt (at least the version in Fedora) does not provide the functions
> anymore for linking:
>
> $ eu-readelf --symbols=.dynsym /lib64/libcrypt.so.1 | grep encrypt
>    38: 000000000000b330     20 FUNC    GLOBAL DEFAULT       12
> encrypt_r@GLIBC_2.2.5
>    52: 000000000000b360     16 FUNC    GLOBAL DEFAULT       12
> encrypt@GLIBC_2.2.5

Yeah, I did that on purpose; the total insecurity of single DES
outweighs standard compliance in this case, I think.  And, as you say,
there probably aren't very many users.

I'll send a revised patch shortly.

zw