From: Zack Weinberg <zackw@panix.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/6] Committed: Remove __need macros from signal.h.
Date: Sun, 21 May 2017 13:55:00 -0000 [thread overview]
Message-ID: <CAKCAbMjE3fmZ74MHoAnwccB_kC4jnX4UcwB_dfrcoG=82BiSsQ@mail.gmail.com> (raw)
In-Reply-To: <m2zie6n0cm.fsf@linux-m68k.org>
On Sun, May 21, 2017 at 3:19 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> /usr/include/bits/types/siginfo_t.h:6:33: fatal error: bits/types/sigval_t.h: No such file or directory
> #include <bits/types/sigval_t.h>
Fixed by appended patch.
Given the difficulty of test-installing glibc and then testing
compilation with it, I would have appreciated somewhat more
explanation of what the problem was, e.g. including the words "Any
program that includes signal.h fails to compile against an installed
glibc with this patch applied" in your message would have saved me
from a couple of false leads.
zw
* signal/Makefile (headers): Add bits/types/sigval_t.h.
---
ChangeLog | 4 ++++
signal/Makefile | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 62341b8ed3..ce060eb8de 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-21 Zack Weinberg <zackw@panix.com>
+
+ * signal/Makefile (headers): Add bits/types/sigval_t.h.
+
2017-05-20 Zack Weinberg <zackw@panix.com>
* bits/sigevent-consts.h
diff --git a/signal/Makefile b/signal/Makefile
index de92558f2c..9ce8232d43 100644
--- a/signal/Makefile
+++ b/signal/Makefile
@@ -28,8 +28,8 @@ headers := signal.h sys/signal.h \
bits/sigstack.h bits/sigthread.h bits/ss_flags.h \
bits/types/__sigset_t.h bits/types/sig_atomic_t.h \
bits/types/sigevent_t.h bits/types/siginfo_t.h \
- bits/types/sigset_t.h bits/types/stack_t.h \
- bits/types/struct_sigstack.h
+ bits/types/sigset_t.h bits/types/sigval_t.h \
+ bits/types/stack_t.h bits/types/struct_sigstack.h
routines := signal raise killpg \
sigaction sigprocmask kill \
--
2.11.0
next prev parent reply other threads:[~2017-05-21 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 23:18 [PATCH 0/6] Elimination of __need macros, round 3(?) Zack Weinberg
2017-05-20 23:18 ` [PATCH 2/6] Committed: Remove __need macros from signal.h Zack Weinberg
2017-05-21 7:19 ` Andreas Schwab
2017-05-21 13:55 ` Zack Weinberg [this message]
2017-05-22 11:18 ` Joseph Myers
2017-05-22 11:25 ` Joseph Myers
2017-05-22 11:59 ` Zack Weinberg
2017-05-23 2:33 ` Zack Weinberg
2017-05-20 23:18 ` [PATCH 3/6] Remove __need macros from errno.h (__need_Emath, __need_error_t) Zack Weinberg
2017-05-20 23:18 ` [PATCH 6/6] Remove __need_schedparam and __cpu_set_t_defined Zack Weinberg
2017-05-20 23:18 ` [PATCH 1/6] Committed: Remove __need_list_t and __need_res_state Zack Weinberg
2017-05-20 23:18 ` [PATCH 4/6] Remove __need macros from stdio.h and wchar.h Zack Weinberg
2017-05-20 23:18 ` [PATCH 5/6] Remove __need_IOV_MAX and __need_FOPEN_MAX Zack Weinberg
2017-05-23 17:42 ` [PATCH 0/6] Elimination of __need macros, round 3(?) Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCAbMjE3fmZ74MHoAnwccB_kC4jnX4UcwB_dfrcoG=82BiSsQ@mail.gmail.com' \
--to=zackw@panix.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).