From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by sourceware.org (Postfix) with ESMTPS id 718913858D29 for ; Sat, 25 May 2024 11:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 718913858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 718913858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716638163; cv=none; b=TEZvT0cZE/rPv1ch340UOFhxqjHli7TGDZE2ixSCaNVqFPdEizxzntdoWFHiRuD9UkBASC3j1AijbYFSUdCmFxMKhJTYrfQPo11rJCG4P5ZY8d3uNTxSQcNXQp7LgVN28PzK97+tQkC/FnY6TD50AooGoAuN98qTd41DyOtLysY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716638163; c=relaxed/simple; bh=BicdDdlB5aw8xInRTTRpyuIdsVD4JKT+zKjxbjoyhdQ=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=s04V37xf1zVwmsuFgG0/bHy+x+KV7IiNkg4sXu2wzNf+/OajZ0bjBvY1nSwWYhzHcrgssfIMf/68tfEFxlsnhAh6OYKL4xUQY0EfIoNTRyNq3UjwDawf3zLVQZuzRElirRIWWI/uj1dbJq/gCcH7FXWq4yLJn9PzJxA5djX1PHY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1f32448e8fbso28718515ad.1 for ; Sat, 25 May 2024 04:56:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716638160; x=1717242960; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fAQNOaqkfU16Yvd8yCaFnsjVXdajpwgoIZvmPKUvUwU=; b=ilvlDxbuTMhf+lB1piMl61gzEFmryWPWgarvmJeH3B0nA0SxPaOv4uJt6K0KK2h5tc KMvk4y2s/+GnEOOMt4B1ZfmkgsDXfqVa4itoXFC5SeE+Ns/lie5FxxFd8tvH3vY3UY7T T8aHrXLpvWbP2iulZf/479JJtM6Kz4Mld90jB7cH3TvYUWFf3lquCUNga7Z2rETC70Ku i+L5SZFPh+Ec9lOJURw3XYxLrSj9IsRUdSPEpQfPhGJCiwudvWAPq8UKbUYXgJpv5A8L tWuor3J4SvF16Zd7YYLT+qIaSB1Kbx9J37QSb+lhkujl3myGcTPkE4J9y7EHQzmXVYvv ooWQ== X-Gm-Message-State: AOJu0YyMqAJKq0UXvy8eUL+EagFpHs34ELYi/H5WpyuRj+yubQFIJXO3 YAK3Y0vZDfJLjwopHX1BSH5XtcGs7hsSdorfd63/Y9WmJ7UEJG8xQW9etrOj X-Google-Smtp-Source: AGHT+IGyEcIdS2X1w91l5pDq0ctxJ8wM+WNkSJs3S5p+PXpdElMQBzRzPvvY3+iq5I7BdU57RdARWw== X-Received: by 2002:a17:903:22cb:b0:1f2:fe12:b7a4 with SMTP id d9443c01a7336-1f4486ba244mr46212675ad.8.1716638159864; Sat, 25 May 2024 04:55:59 -0700 (PDT) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com. [209.85.210.181]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c9705b5sm29665305ad.174.2024.05.25.04.55.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 May 2024 04:55:59 -0700 (PDT) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f8e98784b3so1425935b3a.1 for ; Sat, 25 May 2024 04:55:59 -0700 (PDT) X-Received: by 2002:a05:6a20:3d95:b0:1ad:7ff5:cb38 with SMTP id adf61e73a8af0-1b212f94555mr6103901637.60.1716638159340; Sat, 25 May 2024 04:55:59 -0700 (PDT) MIME-Version: 1.0 References: <20240513081429.1749898-1-syq@gcc.gnu.org> <20240513081429.1749898-2-syq@gcc.gnu.org> <32ca86c8-43bd-4b8b-9956-645124319063@linaro.org> In-Reply-To: <32ca86c8-43bd-4b8b-9956-645124319063@linaro.org> From: YunQiang Su Date: Sat, 25 May 2024 19:55:47 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] MIPSr6/math: Use builtin fma and fmaf To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Adhemerval Zanella Netto =E4=BA=8E2024=E5= =B9=B45=E6=9C=8822=E6=97=A5=E5=91=A8=E4=B8=89 21:42=E5=86=99=E9=81=93=EF=BC= =9A > > > > On 13/05/24 05:14, YunQiang Su wrote: > > MIPSr6 has MADDF.s/MADDF.d instructions, which are fused. > > > > In MIPS ISA, double support can be subsetted. Only FMAF is enabled > > for this case. > > > > * sysdeps/mips/fpu/math-use-builtins-fma.h > > > > Signed-off-by: YunQiang Su > > --- > > sysdeps/mips/fpu/math-use-builtins-fma.h | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > create mode 100644 sysdeps/mips/fpu/math-use-builtins-fma.h > > > > diff --git a/sysdeps/mips/fpu/math-use-builtins-fma.h b/sysdeps/mips/fp= u/math-use-builtins-fma.h > > new file mode 100644 > > index 0000000000..6e296fd4c0 > > --- /dev/null > > +++ b/sysdeps/mips/fpu/math-use-builtins-fma.h > > @@ -0,0 +1,13 @@ > > +#if __mips_isa_rev >=3D 6 > > +# if defined(__mips_single_float) > > Usually for a single case we write as '#ifdef __mips_single_float, > also the identation is a single space. > In fact I sent V2, can you have a look at it? https://sourceware.org/pipermail/libc-alpha/2024-May/156668.html > The rest look ok, gcc seems to emit the the MADDF.X even with > pretty old versions (gcc 5.5.0). > > > +# define USE_FMA_BUILTIN 0 > > +# else > > +# define USE_FMA_BUILTIN 1 > > +# endif > > +# define USE_FMAF_BUILTIN 1 > > +#else > > +# define USE_FMA_BUILTIN 0 > > +# define USE_FMAF_BUILTIN 0 > > +#endif > > +#define USE_FMAL_BUILTIN 0 > > +#define USE_FMAF128_BUILTIN 0