From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
linux-man <linux-man@vger.kernel.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] rtld-audit.7: Clarify la_version handshake
Date: Fri, 25 Sep 2020 19:17:19 +0200 [thread overview]
Message-ID: <CAKgNAkg6wNytOZ4mbO26A6GvDRY1czSvAH1TMpSZogj7kSJzmA@mail.gmail.com> (raw)
In-Reply-To: <1f2734bb-fed4-07f9-94d8-4dbce661b5cf@redhat.com>
On Fri, 25 Sep 2020 at 18:14, Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 9/25/20 6:47 AM, Michael Kerrisk (man-pages) wrote:
> > On 9/25/20 10:48 AM, Florian Weimer wrote:
> >> Returning its argument without further checks is almost always
> >> wrong for la_version.
> >>
> >> Signed-off-by: Florian Weimer <fweimer@redhat.com>
> >
> > Hello Florian,
> >
> > I've applied this patch locally. I'll merge into master
> > in a few hours. Perhaps in the meantime there are acks/reviews
> > that come in.
>
> Just for the record. This version looks good to me and addresses
> my previous comments.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Thanks, Carlos!
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-25 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:48 Florian Weimer
2020-09-25 10:47 ` Michael Kerrisk (man-pages)
2020-09-25 16:14 ` Carlos O'Donell
2020-09-25 17:17 ` Michael Kerrisk (man-pages) [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-23 11:38 Florian Weimer
2020-09-23 11:45 ` Andreas Schwab
2020-09-23 11:47 ` Florian Weimer
2020-09-23 11:52 ` Andreas Schwab
2020-09-23 20:15 ` Ben Coyote Woodard
2020-09-24 1:30 ` Carlos O'Donell
2020-09-25 8:45 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgNAkg6wNytOZ4mbO26A6GvDRY1czSvAH1TMpSZogj7kSJzmA@mail.gmail.com \
--to=mtk.manpages@gmail.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).