public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] manual: Document the System V sigpause function
Date: Sat, 16 May 2020 11:56:00 +0200	[thread overview]
Message-ID: <CAKgNAkj6Qx3BrbRL+E+uCrkCRT0=aMiorUAnk4SOVCeB7vmaBQ@mail.gmail.com> (raw)
In-Reply-To: <87sgg0jkp0.fsf@oldenburg2.str.redhat.com>

Hi Florian,

On Sat, 16 May 2020 at 11:25, Florian Weimer <fweimer@redhat.com> wrote:
>
> * Michael Kerrisk:
>
> >> +@deftypefun int sigpause (int @var{signal})
> >> +@standards{XOPEN, signal.h}
> >> +@safety{@prelim{}@mtunsafe{@mtasurace{:sigprocmask}}@asunsafe{@asulock{/hurd}}@acunsafe{@aculock{/hurd}}}
> >> +This deprecated function is a precursor to the @code{sigsuspend}
> >> +function (@pxref{Waiting for a Signal}): it removes @var{signal} from
> >> +the thread's signal mask, and waits for a signal to arrive.  On return
> >> +the previous set of blocked signals is restored.
> >
> > s/previous set of blocked signals is restored/thread's previous signal
> > mask is restored/ ?
>
> “Set of blocked signals” is the term preferred by the rest of the
> manual.

Maybe so, but:
* "set of blocked signals" is clunky and a bit imprecise (POSIX uses
the term mask)
* In the very preceding line, you yourself wrote "thread's signal mask"...

Maybe the rest of the manual should be fixed?

Thanks,

Michael

  reply	other threads:[~2020-05-16  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 19:07 Florian Weimer
2020-05-12  4:01 ` Carlos O'Donell
2020-05-12  4:59 ` Michael Kerrisk
2020-05-16  9:25   ` Florian Weimer
2020-05-16  9:56     ` Michael Kerrisk (man-pages) [this message]
2020-05-16 10:03       ` Florian Weimer
2020-05-16 10:18         ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKgNAkj6Qx3BrbRL+E+uCrkCRT0=aMiorUAnk4SOVCeB7vmaBQ@mail.gmail.com' \
    --to=mtk.manpages@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).