From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by sourceware.org (Postfix) with ESMTPS id D56CE39A891A for ; Tue, 12 May 2020 07:34:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D56CE39A891A Received: by mail-ej1-x644.google.com with SMTP id x1so10147824ejd.8 for ; Tue, 12 May 2020 00:34:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=mNfP6YBBshYCaKXkTrEaYzOw3XPSbHhjpa+YvHAyjVw=; b=AsmDKCL1lBpmuwIIdf9dKpkQg4zTQtg06PeSuTp32hphx9ExwYPVhqWQRvF1OVcddb 7Ci7amg1UP6LJlo5g2kG6vIv5SS9423TA6hT4jk3/I2vFTtBcEI6C/z1oWCdfWBz0TW4 6XH2TiRhOddCqLcmuBbGNP+TnWsHGk4gE3pRTBn+1Xpc+t6aMZk0nzUb1hKCJOGKfz5u M2kxsoegNIAxYAx2q+qWx8H+RDeOACsbMjQ2ECmW3AL0BCDQfbFUcnXFghWsO6eD7AXa beAqNJ7zjNqd1gzegPeO3V8u2FaZPYqPb46bnX1gO9/QGQHtU8wvdrCwJrly5v6GBKvx 4Yyw== X-Gm-Message-State: AGi0PuZHmoQwnUdva7T2AiZzKzAfvZLVEBEb/YnpsRK6pfC6y5turJd6 kiGoqGnPmCEq6VsOOKSUNAdhaYHhsS43X5PQmJ/G9Q== X-Google-Smtp-Source: APiQypLypQHbssOiQkJt8n/6zPZRhAaRo3lYXZqleBVo0AF/Mr0Qz29LLvySgZcreFJ31G/LTxKvA0MsXdHoL8gDtDI= X-Received: by 2002:a17:906:dbc9:: with SMTP id yc9mr12727602ejb.157.1589268847968; Tue, 12 May 2020 00:34:07 -0700 (PDT) MIME-Version: 1.0 References: <87d07p9v73.fsf@mid.deneb.enyo.de> <87mu6dzkm1.fsf@mid.deneb.enyo.de> In-Reply-To: <87mu6dzkm1.fsf@mid.deneb.enyo.de> Reply-To: mtk.manpages@gmail.com From: "Michael Kerrisk (man-pages)" Date: Tue, 12 May 2020 09:33:57 +0200 Message-ID: Subject: Re: [PATCH] manual: Add Descriptor-Relative Access section To: Florian Weimer Cc: libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 07:34:10 -0000 Hi Florian, [Just by the way, I'm always happy to have you CC me directly on any patch to the glibc manual. It increases the chances that I'll see the mail and be able to take a look and comment. And I often I learn new things from you patches :-).] On Tue, 12 May 2020 at 09:19, Florian Weimer wrote: > > * Michael Kerrisk: > > > One more thought... > > > >> +@itemize @bullet > >> +@item > >> +It can be a file descriptor referring to a directory. Such a descriptor > >> +can be created explicitly using the @code{open} function, with or > >> +without the @code{O_DIRECTORY} flag. > > > > Is it worth mentioning O_PATH here? > > Do you mean like this? > > +It can be a file descriptor referring to a directory. Such a descriptor > +can be created explicitly using the @code{open} function, with or > +without the @code{O_DIRECTORY} amd @code{O_PATH} flags. (s/amd/and/) I'd be inclined to separate out the discussion of O_PATH and O_DIRECTORY, which latter is I think is largely irrelevant to the discussion of dirfds (correct me if I'm wrong) so that I'm not sure it's even necessary to mention O_DIRECTORY. And then in the discussion of O_PATH, you could more explicitly say that the directory can be opened with either O_RDONLY or O_PATH. > And also mention that the file name argument must be non-empty in this > case? Yes, I suppose that would also be helpful. Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/