From: Alistair Francis <alistair23@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Palmer Dabbelt <palmer@sifive.com>,
macro@wdc.com, Zong Li <zongbox@gmail.com>,
Zong Li <zong@andestech.com>
Subject: Re: [RFC v2 05/20] sysdeps/nanosleep: Use clock_nanosleep_time64 if avaliable
Date: Wed, 26 Jun 2019 18:23:00 -0000 [thread overview]
Message-ID: <CAKmqyKMHX+tTt2cuNCPD58TukKkqvpYMMySAgMF+NJqaV6ZwaQ@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3+9qK0RGF86b9CfrZhO6YdPG_eNTZt5D6ZG6+XEiGd6A@mail.gmail.com>
On Tue, Jun 25, 2019 at 1:59 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Jun 25, 2019 at 2:11 AM Alistair Francis
> <alistair.francis@wdc.com> wrote:
>
> > index f14ae565af..c2d6e2f766 100644
> > --- a/sysdeps/unix/sysv/linux/nanosleep.c
> > +++ b/sysdeps/unix/sysv/linux/nanosleep.c
> > @@ -25,7 +25,19 @@ int
> > __nanosleep (const struct timespec *requested_time,
> > struct timespec *remaining)
> > {
> > +
> > +#ifdef __ASSUME_TIME64_SYSCALLS
> > + return SYSCALL_CANCEL (clock_nanosleep_time64, CLOCK_REALTIME, 0,
> > + requested_time, remaining);
> > +#else
> > +# ifdef __NR_clock_nanosleep_time64
> > + long int ret = SYSCALL_CANCEL (clock_nanosleep_time64, CLOCK_REALTIME, 0,
> > + requested_time, remaining);
> > + if (ret == 0 || errno != ENOSYS)
> > + return ret;
> > +# endif
> > return SYSCALL_CANCEL (nanosleep, requested_time, remaining);
> > +#endif
> > }
>
> There has to be a type conversion in here somewhere: If timespec
> uses 32-bit time_t (on all existing 32-bit architectures), you must not
> pass it into __NR_clock_nanosleep_time64, while on builds with
> a 64-bit timespec you must not call nanosleep() without conversion.
>
> I suppose you need something like an internal __nanosleep64 (like
> your function above, but with the conversion added to the fallback
> path) and an internal __nanosleep32 (not calling clock_nanosleep_time64
> or doing conversion). Architectures that have always had a 64-bit time_t
> don't need the latter of course.
Argh, this is a little messy but I think I have something working.
Alistair
>
> No idea how that fits into the rest of the glibc implementation.
>
> Arnd
next prev parent reply other threads:[~2019-06-26 18:23 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 0:11 [RFC v2 00/20] RISC-V glibc port for the 32-bit Alistair Francis
2019-06-25 0:11 ` [RFC v2 12/20] RISC-V: Support dynamic loader " Alistair Francis
2019-06-25 0:11 ` [RFC v2 02/20] y2038: Provide conversion helpers for struct __timespec64 Alistair Francis
2019-06-25 0:11 ` [RFC v2 13/20] RISC-V: Add path of library directories for the 32-bit Alistair Francis
2019-06-25 0:11 ` [RFC v2 07/20] sysdeps/gettimeofday: Use clock_gettime64 if avaliable Alistair Francis
2019-06-27 13:15 ` Adhemerval Zanella
2019-07-03 23:52 ` Alistair Francis
2019-07-24 20:22 ` Joseph Myers
2019-07-24 23:03 ` Alistair Francis
2019-07-25 12:57 ` Arnd Bergmann
2019-07-25 17:03 ` Paul Eggert
2019-07-25 17:21 ` Zack Weinberg
2019-07-25 18:53 ` Arnd Bergmann
2019-07-26 13:01 ` Florian Weimer
2019-07-26 13:08 ` Zack Weinberg
2019-07-25 21:23 ` Joseph Myers
2019-06-25 0:11 ` [RFC v2 01/20] y2038: Introduce internal for glibc struct __timespec64 Alistair Francis
2019-06-25 0:11 ` [RFC v2 03/20] y2038: linux: Provide __clock_settime64 implementation Alistair Francis
2019-06-25 11:05 ` Arnd Bergmann
2019-06-25 15:51 ` Lukasz Majewski
2019-06-25 16:39 ` Arnd Bergmann
2019-06-26 9:07 ` Lukasz Majewski
2019-06-26 12:36 ` Arnd Bergmann
2019-06-26 15:04 ` Lukasz Majewski
2019-06-26 15:11 ` Florian Weimer
2019-06-26 22:49 ` Lukasz Majewski
2019-06-27 7:15 ` Florian Weimer
2019-06-27 7:37 ` Lukasz Majewski
2019-06-26 18:58 ` Arnd Bergmann
2019-06-26 22:55 ` Lukasz Majewski
2019-06-27 7:46 ` Arnd Bergmann
2019-06-27 10:36 ` Lukasz Majewski
2019-06-27 13:32 ` Arnd Bergmann
2019-06-27 14:08 ` Lukasz Majewski
2019-06-27 14:57 ` Arnd Bergmann
2019-06-27 15:23 ` Lukasz Majewski
2019-06-27 15:46 ` Arnd Bergmann
2019-06-27 16:17 ` Lukasz Majewski
2019-06-27 21:26 ` Arnd Bergmann
2019-06-27 22:08 ` Lukasz Majewski
2019-07-04 0:08 ` Alistair Francis
2019-07-04 8:13 ` Lukasz Majewski
2019-07-08 9:32 ` Lukasz Majewski
2019-06-27 20:11 ` Alistair Francis
2019-06-27 21:02 ` Lukasz Majewski
2019-07-08 10:49 ` Joseph Myers
2019-06-25 0:11 ` [RFC v2 10/20] Documentation for the RISC-V 32-bit port Alistair Francis
2019-06-25 0:11 ` [RFC v2 05/20] sysdeps/nanosleep: Use clock_nanosleep_time64 if avaliable Alistair Francis
2019-06-25 8:24 ` Andreas Schwab
2019-06-25 8:59 ` Arnd Bergmann
2019-06-26 18:23 ` Alistair Francis [this message]
2019-06-25 0:12 ` [RFC v2 08/20] sysdeps/wait: Use waitid " Alistair Francis
2019-06-25 8:16 ` Andreas Schwab
2019-06-25 10:55 ` Zack Weinberg
2019-06-25 11:06 ` Florian Weimer
2019-06-25 12:01 ` Arnd Bergmann
2019-06-25 12:10 ` Florian Weimer
2019-06-25 13:30 ` Arnd Bergmann
2019-06-25 13:39 ` Arnd Bergmann
2019-06-25 13:47 ` Florian Weimer
2019-06-25 14:05 ` Arnd Bergmann
2019-06-25 14:08 ` Florian Weimer
2019-06-25 14:21 ` Arnd Bergmann
2019-06-25 14:29 ` Florian Weimer
2019-06-26 14:38 ` Arnd Bergmann
2019-06-26 15:48 ` Florian Weimer
2019-06-26 16:28 ` Andreas Schwab
2019-07-08 12:10 ` Florian Weimer
2019-07-08 12:34 ` Andreas Schwab
2019-07-08 12:37 ` Florian Weimer
2019-07-09 23:00 ` Alistair Francis
2019-07-10 7:34 ` Andreas Schwab
2019-07-10 17:51 ` Alistair Francis
2019-07-25 15:49 ` Joseph Myers
2019-06-26 21:08 ` Arnd Bergmann
2019-06-27 7:33 ` Florian Weimer
2019-06-27 8:25 ` Andreas Schwab
2019-06-27 10:21 ` Arnd Bergmann
2019-06-27 11:12 ` Florian Weimer
2019-06-27 15:24 ` Arnd Bergmann
2019-07-03 23:53 ` Alistair Francis
2019-06-25 23:54 ` Alistair Francis
2019-06-25 0:12 ` [RFC v2 19/20] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2019-06-25 0:12 ` [RFC v2 11/20] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2019-06-25 0:12 ` [RFC v2 14/20] RISC-V: The ABI implementation for the 32-bit Alistair Francis
2019-06-25 0:12 ` [RFC v2 06/20] sysdeps/futex: Use futex_time64 if avaliable Alistair Francis
2019-06-25 11:14 ` Florian Weimer
2019-06-25 11:26 ` Andreas Schwab
2019-06-25 11:41 ` Arnd Bergmann
2019-06-25 12:07 ` Florian Weimer
2019-06-25 13:32 ` Arnd Bergmann
2019-06-25 0:12 ` [RFC v2 15/20] RISC-V: Hard float support for the 32 bit Alistair Francis
2019-06-25 0:12 ` [RFC v2 17/20] RISC-V: Add ABI lists Alistair Francis
2019-06-25 0:12 ` [RFC v2 09/20] sysdeps/getrlimit: Use prlimit64 if avaliable Alistair Francis
2019-06-25 11:11 ` Florian Weimer
2019-06-25 20:48 ` Alistair Francis
2019-06-25 21:10 ` Florian Weimer
2019-06-25 23:41 ` Alistair Francis
2019-06-25 0:12 ` [RFC v2 04/20] include/time.h: Fix conflicting timespec types on 32-bit Alistair Francis
2019-06-25 11:17 ` Arnd Bergmann
2019-06-25 22:23 ` Alistair Francis
2019-06-25 0:12 ` [RFC v2 20/20] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2019-06-25 0:12 ` [RFC v2 16/20] RISC-V: Regenerate ULPs of RISC-V Alistair Francis
2019-06-25 0:12 ` [RFC v2 18/20] RISC-V: Build Infastructure for the 32-bit Alistair Francis
2019-06-25 11:16 ` [RFC v2 00/20] RISC-V glibc port " Florian Weimer
2019-06-25 12:08 ` Arnd Bergmann
2019-07-04 8:47 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKMHX+tTt2cuNCPD58TukKkqvpYMMySAgMF+NJqaV6ZwaQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=arnd@arndb.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=macro@wdc.com \
--cc=palmer@sifive.com \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).