From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101489 invoked by alias); 15 Aug 2019 21:43:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 101481 invoked by uid 89); 15 Aug 2019 21:43:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-lj1-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AkuoGq9F2RdjFM+4uOTWCt0JLNsr8Jmu7nTkcDbboEg=; b=sVkuboAd9BMcZtNBRd8q/2dV4WpyXoq6huzLa7XkGe0ZJ1WdT+r9t/KJuk44YlY1Dj EF1/QwtxIPxO9BIt69to/6u4TyQK/xfhqUj3QaBfnvud5OOWwhRZqbRNjW2CUiJpdu5w Qvkc4wBWovqVZpfmyCb5AspuccDBeK9qbEu9kqNqp/HsVu+F1jSYQTOhwiRme2ylaWEZ dxCdNWvl36PzmfCJLkt6d0jCVLp3AYn9tccDJXD2aDi/xcbHTuKQ/9iC747JF4MwCzEK UqDF8JVXWdCgWKQig/AD8241SvVD73ydO3zBsn9ebeiUtylycu044wfIUZYni0csGjwn bVGw== MIME-Version: 1.0 References: <470d2036c006c525b5dd78b4c7fb860ee521aafd.1565398514.git.alistair.francis@wdc.com> <87h86ja82q.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87h86ja82q.fsf@oldenburg2.str.redhat.com> From: Alistair Francis Date: Thu, 15 Aug 2019 21:43:00 -0000 Message-ID: Subject: Re: [RFC v4 23/24] WIP: syscall.list: Call 64-bit versions of syscalls To: Florian Weimer Cc: Alistair Francis , GNU C Library , Arnd Bergmann , Adhemerval Zanella , Palmer Dabbelt , macro@wdc.com, Zong Li Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-08/txt/msg00423.txt.bz2 On Wed, Aug 14, 2019 at 11:57 AM Florian Weimer wrote: > > * Alistair Francis: > > > On Fri, Aug 9, 2019 at 6:04 PM Alistair Francis > > wrote: > >> > >> Signed-off-by: Alistair Francis > >> --- > >> sysdeps/unix/sysv/linux/syscalls.list | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list > >> index e374f97b5f8..4844d1a9a3b 100644 > >> --- a/sysdeps/unix/sysv/linux/syscalls.list > >> +++ b/sysdeps/unix/sysv/linux/syscalls.list > >> @@ -5,7 +5,7 @@ alarm - alarm i:i alarm > >> bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 > >> capget EXTRA capget i:pp capget > >> capset EXTRA capset i:pp capset > >> -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime > >> +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime > >> create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 > >> delete_module EXTRA delete_module 3 delete_module > >> epoll_create EXTRA epoll_create i:i epoll_create > >> @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam > >> sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler > >> sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max > >> sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min > >> -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval > >> +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval > >> sched_setp - sched_setparam i:ip __sched_setparam sched_setparam > >> sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler > >> sched_yield - sched_yield i: __sched_yield sched_yield > >> @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr > >> mq_setattr - mq_getsetattr i:ipp mq_setattr > >> > >> timerfd_create EXTRA timerfd_create i:ii timerfd_create > >> -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime > >> -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime > >> +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime > >> +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime > > > > Does anyone have ideas/opinions on how to handle this correctly? > > As in many of the other cases, you can add this to : > > #define __NR_timerfd_settime __NR_timerfd_settime64 > #define __NR_timerfd_gettime __NR_timerfd_gettime64 > > Once a second such port arrives, we can factor out these common system > call renamings into a generic-64 subdirectory. Great! That's a straightforward fix. Alistair > > I still think it's just wrong that the kernel doesn't provide these > names as part of the UAPI headers. > > Thanks, > Florian